From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51171C388F9 for ; Tue, 27 Oct 2020 10:09:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA80F21D24 for ; Tue, 27 Oct 2020 10:09:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YzqSbxDM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vwX17LkF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA80F21D24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IBg4bZKWUHlwyEMJ/VLw4UXgaEMfgxS/ngg1h/BTVe4=; b=YzqSbxDMnbi8ICxTq9VJzdeah oDSZGwCf3Sv2tV6lhseI51QrgLdYLY3r8BvFgB/g6231hwbtAjYLA+xoyyfyPL5ROS00D+KNd/EKC NPZhzzzmOj8/bZStVqRw3oXvXX2/Q+T74xeUvKnQmM/zjSprLXncWcydYv6q17MyiheeEtVUmMLjI iOEMVPAc0Gl08vrdOd8pNZaaWZrtP+r0dI5X1h6jelO4VizGLCMPqcjCH77rrdMzIOKlJc7onxDw2 vvZdvDwu5JZFFkJ4KkCUeRk6lZEjqzYJtinMKLJ7vlp4Z3S4aj54T/Lsqr0kgPfjHQTxx9Dvd83R5 rAyI201pQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXLta-0001Rh-Le; Tue, 27 Oct 2020 10:08:02 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXLtX-0001Qy-Lq for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 10:08:00 +0000 Received: by mail-wr1-x441.google.com with SMTP id y12so1181642wrp.6 for ; Tue, 27 Oct 2020 03:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ei3u24rIHuUlXFN659f6wxEdLp7W3x7O+DS6Q5fs7ws=; b=vwX17LkFQN9VmSk/zsSEQ9SxEJQDJ1JMaJs+RIlkwFQEf8BtkIDogxkC8/t6kyWU0v /CwB8tyGJ6i4O6Xem4VotrXV/uNJawEstv4Yn2RYmspGd7zL1sf1sbngmLvxDXxB8GQ1 dtrfpW8+AzdqfUXI4E/LTFGw1dQmg0GgzOeWnygoEs3Sdoom7CGu3hxhcghgadqPNvwD jeyx1ag8UrJgIFlbvVhaX9CYZgHMI92OB1w/7xtexYykY6E4+pPFpPqjD9ej1lPlinLJ rmzy62ttsrCoHyo/5DD84nM7F2/B/ApC/Vpu3uB8JuY3ziXSFdGxLSlaUqTUmHq19ESa FcMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ei3u24rIHuUlXFN659f6wxEdLp7W3x7O+DS6Q5fs7ws=; b=X3JfNwGzpP5JEsAV7WaBvS9M58+V6Q4fD9uyyoMhNJvJTitC5XKgTKvrzPsgK2XDU4 Uh2yzIC3BAmDvAFLgPXN86gmO3u97KC/zYddRpOvXUZDttfEs+Qoss/6m6rjK27XFsgM CLjh5pupbH9IxXKB3zvwdkvqwHPIsF2ZXF1keFkafcdwX0550RHWM4x4QKsqIrxfh/Ao qQr4Gaz1OJHjmiCbieFa8hyf1TH188NvxIrnNFroA+nEyJayxadW69X5hF0YBMse0KOK ULjIpUYCOva89NXXGr5F2/s6L/OlfFG5awm8SxlrrNbRLR0MkoDKmJ8sV5XRF++Ntpnc bzEQ== X-Gm-Message-State: AOAM5320M1t0m2+5a0R57xerANobGveu83zcrfsW5iv13TFq/hRr+Zda RyIyt2AaQToKMeu4BYADqSXhgQ== X-Google-Smtp-Source: ABdhPJzc7V2HgcIEkvba+6199zd1BCJe8hFyMd14K8tTvw55Goq1lfkLy50L41t3mH0cpHB5Sr7eWQ== X-Received: by 2002:adf:e751:: with SMTP id c17mr1229850wrn.345.1603793277117; Tue, 27 Oct 2020 03:07:57 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id i33sm1463259wri.79.2020.10.27.03.07.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2020 03:07:56 -0700 (PDT) Subject: Re: [PATCH v12 1/2] ASoC: google: dt-bindings: Add sc7180-trogdor machine bindings To: Cheng-Yi Chiang , linux-kernel@vger.kernel.org References: <20201027032234.1705835-1-cychiang@chromium.org> <20201027032234.1705835-2-cychiang@chromium.org> From: Srinivas Kandagatla Message-ID: <1f5f9ee9-f77c-7142-efe4-7e845fe54953@linaro.org> Date: Tue, 27 Oct 2020 10:07:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201027032234.1705835-2-cychiang@chromium.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_060759_765517_50EF31D4 X-CRM114-Status: GOOD ( 22.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , alsa-devel@alsa-project.org, Banajit Goswami , Heiko Stuebner , Liam Girdwood , Rohit kumar , Ajye Huang , Patrick Lai , Andy Gross , dgreid@chromium.org, Jaroslav Kysela , devicetree@vger.kernel.org, tzungbi@chromium.org, Srinivasa Rao , Stephan Gerhold , linux-arm-msm@vger.kernel.org, Rob Herring , Matthias Brugger , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, dianders@chromium.org, Takashi Iwai , xuyuqing@huaqin.corp-partner.google.com, Mark Brown Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for doing this! On 27/10/2020 03:22, Cheng-Yi Chiang wrote: > Add devicetree bindings documentation file for sc7180 sound card. > > Signed-off-by: Cheng-Yi Chiang Looks good to me! Reviewed-by: Srinivas Kandagatla > --- > Changes from v11 to v12 > - Documentation: > - Change the file and title name for new compatible string google,sc7180-trogdor. > - Change the example of model name. > > .../bindings/sound/google,sc7180-trogdor.yaml | 130 ++++++++++++++++++ > 1 file changed, 130 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > > diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > new file mode 100644 > index 000000000000..efc34689d6b5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > @@ -0,0 +1,130 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/google,sc7180-trogdor.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google SC7180-Trogdor ASoC sound card driver > + > +maintainers: > + - Rohit kumar > + - Cheng-Yi Chiang > + > +description: > + This binding describes the SC7180 sound card which uses LPASS for audio. > + > +properties: > + compatible: > + const: google,sc7180-trogdor > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^dai-link(@[0-9])?$": > + description: > + Each subnode represents a dai link. Subnodes of each dai links would be > + cpu/codec dais. > + > + type: object > + > + properties: > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > + reg: > + description: dai link address. > + > + cpu: > + description: Holds subnode which indicates cpu dai. > + type: object > + properties: > + sound-dai: true > + > + codec: > + description: Holds subnode which indicates codec dai. > + type: object > + properties: > + sound-dai: true > + > + required: > + - link-name > + - cpu > + - codec > + > + additionalProperties: false > + > +required: > + - compatible > + - model > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false > + > +examples: > + > + - | > + sound { > + compatible = "google,sc7180-trogdor"; > + model = "sc7180-rt5682-max98357a-1mic"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dai-link@0 { > + link-name = "MultiMedia0"; > + reg = <0>; > + cpu { > + sound-dai = <&lpass_cpu 0>; > + }; > + > + codec { > + sound-dai = <&alc5682 0>; > + }; > + }; > + > + dai-link@1 { > + link-name = "MultiMedia1"; > + reg = <1>; > + cpu { > + sound-dai = <&lpass_cpu 1>; > + }; > + > + codec { > + sound-dai = <&max98357a>; > + }; > + }; > + > + dai-link@2 { > + link-name = "MultiMedia2"; > + reg = <2>; > + cpu { > + sound-dai = <&lpass_hdmi 0>; > + }; > + > + codec { > + sound-dai = <&msm_dp>; > + }; > + }; > + }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel