From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AF55C3DA6D for ; Tue, 20 May 2025 07:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H/l7rVvT7IdNaigLF2y6iQdv9L3NaIAZJJfWm8xB9zQ=; b=pzlhUTuETFphQxZvW99XjWj1Ja niP3np/LYXdabH8C3UgJVCuRG6uQQ2UeqerunYogEEzq5TRK7UHFUxR4+JeEdl052awln/cQVJn3w 3zB4aRetKPrfcx1r6evp/j7qY5mss4Bkdljhlq3SXUABmoDrQaj4HKIPD2mqsaWij1tmYowcM7WKk V/sCAu/Irt2xNu3vKnZB+s6WGrrLozNDpXgbqTIrLhBk4SSMhkC+U3cLONsK0yYCC4kEnL49Mgf/w bmhtq6e24FSUgEYHAWqcHpCeJnrpPBM0hd0BeZ7/q0aPjHhREqtK0f3ioNe4z71RczqmTgZqJ1IXN P7g3lXmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uHHev-0000000Btdq-3nC4; Tue, 20 May 2025 07:45:09 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uHHcm-0000000Bt7o-1mOv; Tue, 20 May 2025 07:42:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9228BA4DEAC; Tue, 20 May 2025 07:42:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E466C4CEEF; Tue, 20 May 2025 07:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747726975; bh=We+cooXol/fNixHdbPL5YUpqXHGi1HULXp8uxcV/F3o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tvWWdfz+KPUpt6Ym0juySnOuAYIGqeEqzMRrQabicXt7wN+R2UTeYjF3uL6XGFfFx X4+aZcKAK/G5KZJK3Ubed5xrtpTK6GgbivCAHZetAhUEWkrEiXTGjN9ejK3PLGUlRk itz2U0rgWumrfDgb4Dkfg+YPLFNtD2Y8ztC5Jr5rakrbCg4W33GnzBJ+OMmyahANx1 l+nPH2nVDdam6zWjLWD93wJsk0RhR38TtxX1wAUfdl5h3Jge8wckHTnKZnVPu4fdhe mfDX1hJgGQffiq5t9eWfJf5EvQg6wq+AWZUAh1Ec+HAHYeEarqp4Cwdg5vyR5ENP+6 u0sf4pCi6la7A== Message-ID: <1f63af35-7d10-434b-b802-115611ce2ed6@kernel.org> Date: Tue, 20 May 2025 09:42:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] phy: exyons5-usbdrd: support HS phy for ExynosAutov920 To: Neil Armstrong , Pritam Manohar Sutar , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com, andre.draszik@linaro.org, peter.griffin@linaro.org, kauschluss@disroot.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rosa.pila@samsung.com, dev.tailor@samsung.com, faraz.ata@samsung.com, muhammed.ali@samsung.com, selvarasu.g@samsung.com References: <20250516102650.2144487-1-pritam.sutar@samsung.com> <20250516102650.2144487-3-pritam.sutar@samsung.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250520_004256_611971_5BF19270 X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/05/2025 09:39, neil.armstrong@linaro.org wrote: >> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c >> index 634c4310c660..b440b56c6595 100644 >> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c >> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c >> @@ -177,6 +177,9 @@ >> #define HSPHYPLLTUNE_PLL_P_TUNE GENMASK(3, 0) >> >> /* Exynos850: USB DRD PHY registers */ >> +#define EXYNOSAUTOv920_DRD_CTRL_VER 0x00 >> +#define CTRL_VER_MAJOR_VERSION GENMASK(31, 24) >> + >> #define EXYNOS850_DRD_LINKCTRL 0x04 >> #define LINKCTRL_FORCE_RXELECIDLE BIT(18) >> #define LINKCTRL_FORCE_PHYSTATUS BIT(17) >> @@ -1772,6 +1775,10 @@ static const char * const exynos5_regulator_names[] = { >> "vbus", "vbus-boost", >> }; >> >> +static const char * const exynosautov920_clk_names[] = { >> + "ext_xtal", >> +}; >> + >> static const struct exynos5_usbdrd_phy_drvdata exynos5420_usbdrd_phy = { >> .phy_cfg = phy_cfg_exynos5, >> .phy_ops = &exynos5_usbdrd_phy_ops, >> @@ -1847,6 +1854,81 @@ static const struct exynos5_usbdrd_phy_drvdata exynos850_usbdrd_phy = { >> .n_regulators = ARRAY_SIZE(exynos5_regulator_names), >> }; >> >> +static void exynosautov920_usbdrd_utmi_init(struct exynos5_usbdrd_phy *phy_drd) >> +{ >> + u32 version; >> + >> + version = readl(phy_drd->reg_phy + EXYNOSAUTOv920_DRD_CTRL_VER); >> + dev_info(phy_drd->dev, "usbphy: version:0x%x\n", version); > > Please do not add mode info to boot log, use dev_dbg instead. Just drop entirely, not even worth dbg (see coding style, driver development debugging guide). It is fixed per given compatible, isn't it? If not, there is entire commit msg to explain unusual things. > >> + >> + if (FIELD_GET(CTRL_VER_MAJOR_VERSION, version) == 0x3) >> + /* utmi init for exynosautov920 HS phy */ >> + exynos850_usbdrd_utmi_init(phy_drd); >> +} >> + >> +static int exynosautov920_usbdrd_phy_init(struct phy *phy) >> +{ >> + struct phy_usb_instance *inst = phy_get_drvdata(phy); >> + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); >> + int ret = 0; >> + >> + ret = clk_bulk_prepare_enable(phy_drd->drv_data->n_clks, phy_drd->clks); >> + if (ret) >> + return ret; >> + >> + /* UTMI or PIPE3 specific init */ >> + inst->phy_cfg->phy_init(phy_drd); >> + >> + clk_bulk_disable_unprepare(phy_drd->drv_data->n_clks, phy_drd->clks); >> + >> + return 0; >> +} >> + >> +static void exynosautov920_v3p1_phy_dis(struct phy *phy) >> +{ >> + struct phy_usb_instance *inst = phy_get_drvdata(phy); >> + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); >> + void __iomem *reg_phy = phy_drd->reg_phy; >> + u32 version; >> + >> + version = readl(reg_phy + EXYNOSAUTOv920_DRD_CTRL_VER); >> + >> + if (FIELD_GET(CTRL_VER_MAJOR_VERSION, version) == 0x3) >> + exynos850_usbdrd_phy_exit(phy); >> +} >> + >> +static int exynosautov920_usbdrd_phy_exit(struct phy *phy) >> +{ >> + struct phy_usb_instance *inst = phy_get_drvdata(phy); >> + >> + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) >> + exynosautov920_v3p1_phy_dis(phy); >> + >> + return 0; >> +} >> + >> +static const struct phy_ops exynosautov920_usbdrd_phy_ops = { >> + .init = exynosautov920_usbdrd_phy_init, >> + .exit = exynosautov920_usbdrd_phy_exit, > > > >> + .id = EXYNOS5_DRDPHY_UTMI, >> + .phy_init = exynosautov920_usbdrd_utmi_init, > > > >> + }, { >> + .compatible = "samsung,exynosautov920-usb31drd-phy", >> + .data = &exynosautov920_usb31drd_phy > > All those new ops are only called when matching this compatible, it it really > necessary to check the version ? is there "samsung,exynosautov920-usb31drd-phy" PHYs > with version different from 3 in the wild ? Yeah, this looks like downstream code. Anyway this would need explanation in the commit msg. Best regards, Krzysztof