From: Mukesh Ojha <mojha@codeaurora.org>
To: Anson Huang <anson.huang@nxp.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
Date: Mon, 1 Apr 2019 13:31:05 +0530 [thread overview]
Message-ID: <1fae9beb-1dbc-5e62-a39e-57ae5d8e7671@codeaurora.org> (raw)
In-Reply-To: <1554095960-15638-1-git-send-email-Anson.Huang@nxp.com>
On 4/1/2019 10:54 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/pwm/pwm-imx27.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 8061306..434a351 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
> static int pwm_imx27_probe(struct platform_device *pdev)
> {
> struct pwm_imx27_chip *imx;
> - struct resource *r;
>
> imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
> if (imx == NULL)
> @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
> imx->chip.of_xlate = of_pwm_xlate_with_flags;
> imx->chip.of_pwm_n_cells = 3;
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(imx->mmio_base))
> return PTR_ERR(imx->mmio_base);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-01 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 5:24 [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 7:00 ` Uwe Kleine-König
2019-04-01 7:45 ` Mukesh Ojha
2019-04-01 8:00 ` Mukesh Ojha
2019-04-01 8:01 ` Mukesh Ojha [this message]
2019-04-28 6:29 ` Anson Huang
2019-05-09 14:55 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fae9beb-1dbc-5e62-a39e-57ae5d8e7671@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).