From: Yicong Yang <yangyicong@huawei.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>,
<sudeep.holla@arm.com>, <tglx@linutronix.de>,
<peterz@infradead.org>, <mpe@ellerman.id.au>,
<linux-arm-kernel@lists.infradead.org>, <mingo@redhat.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>,
<yangyicong@hisilicon.com>, <linuxppc-dev@lists.ozlabs.org>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<jonathan.cameron@huawei.com>, <prime.zeng@hisilicon.com>,
<linuxarm@huawei.com>, <xuwei5@huawei.com>,
<guohanjun@huawei.com>
Subject: Re: [PATCH v5 1/4] cpu/SMT: Provide a default topology_is_primary_thread()
Date: Mon, 19 Aug 2024 15:25:18 +0800 [thread overview]
Message-ID: <1feb896c-e2aa-2ae5-eb7e-dd28bfb40034@huawei.com> (raw)
In-Reply-To: <9c46d5f0-f4ff-461b-b483-840fab6dfecc@arm.com>
On 2024/8/16 23:54, Dietmar Eggemann wrote:
> On 06/08/2024 10:53, Yicong Yang wrote:
>> From: Yicong Yang <yangyicong@hisilicon.com>
>>
>> Currently if architectures want to support HOTPLUG_SMT they need to
>> provide a topology_is_primary_thread() telling the framework which
>> thread in the SMT cannot offline. However arm64 doesn't have a
>> restriction on which thread in the SMT cannot offline, a simplest
>> choice is that just make 1st thread as the "primary" thread. So
>> just make this as the default implementation in the framework and
>> let architectures like x86 that have special primary thread to
>> override this function.
>
> IMHO, ARM64 (/ARM), RISCV and PARISC (SMP) use GENERIC_ARCH_TOPOLOGY
> (and drivers/base/arch_topology.c) so they could share
> topology_is_primary_thread() also there?
>
I think yes, if they want to implement HOTPLUG_SMT and don't have a restriction
on the primary thread.
Thanks.
next prev parent reply other threads:[~2024-08-19 8:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 8:53 [PATCH v5 0/4] Support SMT control on arm64 Yicong Yang
2024-08-06 8:53 ` [PATCH v5 1/4] cpu/SMT: Provide a default topology_is_primary_thread() Yicong Yang
2024-08-16 15:54 ` Dietmar Eggemann
2024-08-19 7:25 ` Yicong Yang [this message]
2024-08-06 8:53 ` [PATCH v5 2/4] arch_topology: Support SMT control for OF based system Yicong Yang
2024-08-16 15:55 ` Dietmar Eggemann
2024-08-19 7:18 ` Yicong Yang
2024-08-06 8:53 ` [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI " Yicong Yang
2024-08-16 15:55 ` Dietmar Eggemann
2024-08-19 7:03 ` Yicong Yang
2024-08-22 7:19 ` Dietmar Eggemann
2024-08-27 15:40 ` Pierre Gondois
2024-08-29 7:40 ` Yicong Yang
2024-08-29 12:46 ` Pierre Gondois
2024-08-30 9:35 ` Yicong Yang
2024-09-02 7:43 ` Pierre Gondois
2024-09-03 12:44 ` Yicong Yang
2024-09-05 8:34 ` Pierre Gondois
2024-09-05 12:02 ` Yicong Yang
2024-09-06 7:06 ` Morten Rasmussen
2024-09-06 8:36 ` Yicong Yang
2024-09-12 11:59 ` Morten Rasmussen
2024-09-12 12:53 ` Michal Suchánek
2024-08-06 8:53 ` [PATCH v5 4/4] arm64: Kconfig: Enable HOTPLUG_SMT Yicong Yang
2024-08-27 15:40 ` Pierre Gondois
2024-08-29 6:50 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1feb896c-e2aa-2ae5-eb7e-dd28bfb40034@huawei.com \
--to=yangyicong@huawei.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xuwei5@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).