From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A18FCA5FF1 for ; Wed, 7 Oct 2026 08:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L3WmTcY7Cx2LB7n34xA1mszrSAOkEucT8groA+9/JLE=; b=k7ITSJg1e2Ji8klx0ycHnU+pb5 iQSnsObnJkQRHhtt2vgA23+QujLdZusK4enT98xQc31Q6CZsp8dafgHfLZGeUV8eUhMi9AeOYCUtb PgqhGzvJSiFpLF8M4D8TxmrvIG+544OomCqhwk6BW/eMJgCibxy2ledACbxsaBwY2+P4dHohJT7qm N1LHprO0GUIM0arDUdeX1yjhL8kpX9WZJojv4jBjG6ObA5mFqYNOQjd5JQfM4OiAcegtuZwYxreYS DXuzgFQk58rjomOA+t5Fkwh4hx7rGVoIHYVD/j2w01sGUZwffTHO52S3ihcCB2oGcg9miWtOGapNx eKZh9SHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xENKX-00000001yvF-1SWZ; Wed, 07 Oct 2026 08:48:53 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xENKV-00000001yuK-0N6D for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2026 08:48:52 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4a16aaf2067so42984895e9.0 for ; Wed, 07 Oct 2026 01:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791362929; x=1791967729; darn=lists.infradead.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L3WmTcY7Cx2LB7n34xA1mszrSAOkEucT8groA+9/JLE=; b=k4Avs+XVSiqewAFVG40RPgfxh8A2cDUX1HvoZPL8s2yghpmFb+Jdb8AC6RWLjV5iPJ 1Dv7Wj//BNyJuULcPSEGe1lWaZCh+gQt07CV0OV9MJb/khTkDTUXPjqhWvI/GL3ljqn7 1qfCzuPBm8BK0UYWFtjxpeBIiWkOdyPfAHUZUYXTKtKV5JHiI5s04qu33HbH0f6hg3C1 ZdOzpKgOrjwxrsoTUeExLhLSQWfWy52TcXpx8S42Zvwzktpr90l61WSmOVzhcoDCXnF0 g72DYL4Eb5/TNyhxso9K7mScsM8fOZd/j/U6Ys1oNedF26vCmBhxUZMOORjwVcrl6Oxw ht6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791362929; x=1791967729; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=L3WmTcY7Cx2LB7n34xA1mszrSAOkEucT8groA+9/JLE=; b=ykrhDahBRWL3Q5d3FPHymXsc/Y+4e6GTgAWJ8/urW3jx83OQ+8GyIjA/45JS/xvin4 fMfoxP4JOeB5Zscchi/Px75649xD1G4vEBU92Tp7ybuBJHQOQlc3YB81eeDDwpvCHKU/ WKZSEu3RsJqi1zB3BDGkTSecGGVNTR/XKoTqNVsdgwoxqafbYwzeajPdznHthx5U1YXR DRXR/6HWjry7QoS3s01zF1xZN8hhoJwRNaPJeoyG+1akVWfbEi+cWbFa6SP6KFpxT3Gs V7Y72PqkRr/+zR5DMo+wawJ2mLP1nDt8cpKlBzF+72R1LVGBrtBryx7dZ58iYdgSvTbi ZYqQ== X-Forwarded-Encrypted: i=1; AKwUvByn0h0TLOK52f8Cd0OreM/8hA+QS1jE81uaXOr2KCx3MzHE4242oFwSnokzeT9MyxV3q2vfBlrqEGRcgGL4Li6I@lists.infradead.org X-Gm-Message-State: AFuF++nrOnQTBBo4+ke+8MoXNplldhlF3BtSi1chlHDniDl7xDPr0zlA OGqJY4qkYnxNX3KPUEmAqAFKEdZzprMc0C1MUwoHvcqe5CX/u9JUi+vnPQA53aW/JM0= X-Gm-Gg: AYBFou1TOtktRqZ8nSoyi7O7cmz+NXQnQfOWPMr2gQd541tyWoat8WZsA6vm+4VglOD 7F3jge+EDlg5/59mFeutshC/mPC+zZIzqfs/Wx8d/eTwKuNSF8BiYdXRHVcn3KnimNR7CQp07MA hJA+mf6qv+WnNqJ/WeSXFbe0WBiJdiEvkULsESb5j8GxhQ2T/AtcZzOD3+QUELxVuRhlLmp2KbE JakOqpFPIopY3HyfxJ6cXhXVCXEaFLbaDFLaSqscOpxWJp5dsJBphe+lexbJPbsgPSvVmmWtsIE VPEXXENkdMDBoJ7TiplSKt2ZCoFY19Sp6JEHkhQXL9sQYQeOU/7ctRlNZR2MQR53jbB+pvvgj7U wlcuEFgpt/jA/HNIE062f0eI+L5URn7IoWl8ramei1MAkSmaEy25OvrSBFd84ht3j1vY72WrmNo RZcrAVJITC7KQ+Oja/5gDiYfyc+6pPL1rhdy6NB/Nf0ttj9j5b2NQg2KzLgNhZ9VrJhX6NlhCVJ TVpXcXxy5TvOmY= X-Received: by 2002:a05:600c:4687:b0:4a1:7811:6cc4 with SMTP id 5b1f17b1804b1-4a180650943mr24592905e9.34.1791362929425; Wed, 07 Oct 2026 01:48:49 -0700 (PDT) Received: from localhost (90-182-211-1.rcp.o2.cz. [90.182.211.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a17f558028sm58745425e9.10.2026.10.07.01.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 01:48:48 -0700 (PDT) From: Jerome Brunet To: Valerio Setti , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Valerio Setti Subject: Re: [PATCH v4 5/7] ASoC: meson: aiu: add I2S Capture DAI In-Reply-To: <20261001-audin-v4-5-2476646118b5@baylibre.com> References: <20261001-audin-v4-0-2476646118b5@baylibre.com> <20261001-audin-v4-5-2476646118b5@baylibre.com> Date: Wed, 07 Oct 2026 10:48:46 +0200 Message-ID: <1j33uhzyj5.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261007_014851_151754_9E1CA66A X-CRM114-Status: GOOD ( 23.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 01 Oct 2026 at 18:06, Valerio Setti wrote: > Add capture stream to CPU_I2S_ENCODER making it able to handle both > playback and capture streams. Captured data is formatted from > "audin-formatter-i2s" widget, buffered from "audin-fifo" into an internal > FIFO and then bulk transmitted into RAM when the FIFO is full. > > As for the naming of the stream "I2S Encoder" is kept as base following > the same pattern used for the playback stream and with the goal to minimize > changes. > > Supported format for capture is currently limited to S16_LE because it's > the only one that has been tested. According to the manual also S24_LE > should be supported, but this is kept as follow-up. --- > > This capture support also takes advantage of the following commits that > has recently been merged: > > commit df3c987ab3d7 ("ASoC: meson: aiu-encoder-i2s: reflect bs quirk in hw constraints") > commit e82159384a50 ("ASoC: meson: aiu-encoder-i2s: use the core symmetric_rate handling") > > They ensure bs_quirk and rate symmetry across playback and capture streams. > I don't think this part of the description is necessary. Apart from that Reviewed-by: Jerome Brunet > Signed-off-by: Valerio Setti > --- > sound/soc/meson/aiu.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c > index 535fbf7c1639..14d0e20a4bd6 100644 > --- a/sound/soc/meson/aiu.c > +++ b/sound/soc/meson/aiu.c > @@ -153,6 +153,13 @@ static struct snd_soc_dai_driver aiu_cpu_dai_drv[] = { > .rates = SNDRV_PCM_RATE_8000_192000, > .formats = AIU_FORMATS, > }, > + .capture = { > + .stream_name = "I2S Encoder Capture", > + .channels_min = 2, > + .channels_max = 2, > + .rates = SNDRV_PCM_RATE_8000_192000, > + .formats = SNDRV_PCM_FMTBIT_S16_LE, > + }, > .ops = &aiu_encoder_i2s_dai_ops, > .symmetric_rate = 1, > }, > > -- > 2.47.3 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Jerome