From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C66FCCF9F8 for ; Thu, 30 Oct 2025 08:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u6Foz8MaHxrmEMOx8NcxHNFwNAdtDbaYeCNwJR7rWXU=; b=ocQi1SyKLddetaf/4lQeuCRpl8 XW12/rPJlsUpFjZ6f1069H/9vGmha7nnsOt+Zu04aDlK4bNknEziqboF6zxBqtiRrPxM5M+f3aBdR pz/Ad+W5ZyveIuPTeMeBeJe1Fe2RASKT2U4Dfmk5ROG92TDamwqjsL1QhZ+0FlZTh6vnuAucOgZZG sks0EvpEGZ9sKexL2mJIJboNx8TTvG3hR4hzSObpmhy0KzH/0J5yCw3mabAfuEqLcXUXl43+JxNqM zmPomSAFLUwx1kiXhAI4qQ3rnMsUgPlYR+4ln2fs50I/ts8Iw7hMBW+qrkHxmK4iJLkq9TWgfcEY0 wPr2ETKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEODD-00000003luB-1EGE; Thu, 30 Oct 2025 08:40:51 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEODA-00000003ltN-03zq for linux-arm-kernel@lists.infradead.org; Thu, 30 Oct 2025 08:40:49 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-426f1574a14so491344f8f.3 for ; Thu, 30 Oct 2025 01:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1761813646; x=1762418446; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=u6Foz8MaHxrmEMOx8NcxHNFwNAdtDbaYeCNwJR7rWXU=; b=cJoJ5/5zZi/US9P6jB2i+gTYUxUkDXqaFQLxlEShsMLN9LJTx1R1+m+NTqI57IVA8a f+FMbd0h0bWJihFU8kuxhhMfUNH/c7noiEF86kVkN4FWHAZIbg+gAjgPWAsozQVwvE12 bGuNglOOYaw2DDOzif4cNjRUFIl8Osca7H137tYgdeslhWwG7qe0flQHbZKq3xCnJSfS nU1prmtM20f35JOBzQiGrpX4j4tjBOKxeAkCDlNZf7Ke2LSLFfdsyPqJioLkTNZ2f8rq kBqKJl5VnMMC6kkpOjplvcM9LpQwZAvUYjmjz4uo6zI5JqSzkV6MSz/LcjpGiad968Nq +4Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761813646; x=1762418446; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u6Foz8MaHxrmEMOx8NcxHNFwNAdtDbaYeCNwJR7rWXU=; b=AWnxwBS7BB9qf4LubmUy56SDY1jDWTfHJaJzIpoCzQ+Pm7/MjDutCsl4qunfpfrV4m 79PTVKwr+IsL1WAbfcLcyIckRrgsXArb47fRhFBy0UmuSz7WWBlxs2H+q2sx8WhbClx2 wSx30WRh5shW6QgcUZggtKiYouBPKAIsKIlI9dAo6oyvD3h3nDGuluPeWrixwKLb1AX4 Um/6x6+9w+PPG+/aq5gthOJwuBukkJ2aP69aRPpcWND4w3pzkeNZRaci5FM5Jbpxtos4 MHDwuawNvTAgBojU7DAqhFRCMBa1dKFr/y5ivOlCLlro5XjXdGEV2v/nk+QMWkJEftUg DrCw== X-Forwarded-Encrypted: i=1; AJvYcCVMaAhbdkYbJz4BVH2XLzN6PIP7v4lyn0eBxETP6yZJGroIFl2rklxHJMEB8C/OqYhjGwddWWMNN33fLoJv2FU0@lists.infradead.org X-Gm-Message-State: AOJu0Yyfqc9Ka74UNMXyONORncqLnuRoaDpmgusX26AreLxBLw3CcTBo 96v8mR8AlmBNoT+3ovGuslCJtdUtjSSdxbWd7uv7ibbaRkn+23iv1PFM1h1NqPWs8lQ= X-Gm-Gg: ASbGncvd7fQy1qz3p7P6cwe1k5LLj2XaeO1gmjmal4E05VMfNwXe24tG9XOsPwGec9q bM/yYhF4T4tDSQP4ZOrxa9qMQRvJPwhAqV9q+esiOIBuJMmQWr0DOK9SoKNERSnUmVNj2DrGzJK iGC9yRlR546/agD0k4FDPEelIB4ukHtgaN6DaaLSdx7enpN0PS5fBUVKIVnLYLjLorJqKEKmaAR s1YLKJGdhiYlvXgjNg5R0Z+hs3R5adAX/CjFtMeDHGio7ja5piUbmmw0z/fpLhhPHXVWkT4TFWr d+f5NvCpeB2Q2EtTAcpalcfYn4HM19/HyMCFuIYn30pG5oUAC+/lCni6C+yEqDqvns9v5Q/NgNt zqxdpiMFRxs+pQWSB4HRxnGIrC4S52gAe2Qzw3weTkmYnsaKCROfbFrrbEUAaFQrj7e/YhR6h7n 6WQh120u48 X-Google-Smtp-Source: AGHT+IGwgkS7kM3RE06V/HkLJNjMRlWeQ3z1eYRlCMXE2II174VLn8RIAaLYjqz/6xJH+FF23reQDg== X-Received: by 2002:a5d:64c8:0:b0:426:d53a:fbb6 with SMTP id ffacd0b85a97d-429aefafca2mr5110907f8f.31.1761813646130; Thu, 30 Oct 2025 01:40:46 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:64bd:9043:d05:7012]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429952b7a7csm30904879f8f.8.2025.10.30.01.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 01:40:44 -0700 (PDT) From: Jerome Brunet To: Chuan Liu via B4 Relay Cc: Neil Armstrong , Michael Turquette , Stephen Boyd , Kevin Hilman , Martin Blumenstingl , chuan.liu@amlogic.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, da@libre.computer Subject: Re: [PATCH v2 5/5] clk: amlogic: Change the active level of l_detect In-Reply-To: <20251030-optimize_pll_driver-v2-5-37273f5b25ab@amlogic.com> (Chuan Liu via's message of "Thu, 30 Oct 2025 13:24:15 +0800") References: <20251030-optimize_pll_driver-v2-0-37273f5b25ab@amlogic.com> <20251030-optimize_pll_driver-v2-5-37273f5b25ab@amlogic.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 30 Oct 2025 09:40:43 +0100 Message-ID: <1j4irgzss4.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251030_014048_091422_157C8E89 X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 30 Oct 2025 at 13:24, Chuan Liu via B4 Relay wrote: > From: Chuan Liu > > l_detect controls the enable/disable of the PLL lock-detect module. > > The enable signal is normally active-high. This design ensures that > the module remains disabled during the power-on process, preventing > power fluctuations from affecting its operating state. > > For A1, the l_detect signal is active-low: > 0 -> Enable lock-detect module; > 1 -> Disable lock-detect module. > > Here, a flag CLK_MESON_PLL_L_DETECT_N is added to handle cases like > A1, where the signal is active-low. Given that A1 is the only ship supporting l_detect, this change is not necessary. Not now at least. > > Signed-off-by: Chuan Liu > --- > drivers/clk/meson/a1-pll.c | 1 + > drivers/clk/meson/clk-pll.c | 16 ++++++++++++---- > drivers/clk/meson/clk-pll.h | 2 ++ > 3 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/meson/a1-pll.c b/drivers/clk/meson/a1-pll.c > index 1f82e9c7c14e..bfe559c71402 100644 > --- a/drivers/clk/meson/a1-pll.c > +++ b/drivers/clk/meson/a1-pll.c > @@ -137,6 +137,7 @@ static struct clk_regmap a1_hifi_pll = { > .range = &a1_hifi_pll_range, > .init_regs = a1_hifi_pll_init_regs, > .init_count = ARRAY_SIZE(a1_hifi_pll_init_regs), > + .flags = CLK_MESON_PLL_L_DETECT_N > }, > .hw.init = &(struct clk_init_data){ > .name = "hifi_pll", > diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c > index c6eebde1f516..d729e933aa1c 100644 > --- a/drivers/clk/meson/clk-pll.c > +++ b/drivers/clk/meson/clk-pll.c > @@ -384,8 +384,12 @@ static int meson_clk_pll_enable(struct clk_hw *hw) > meson_parm_write(clk->map, &pll->rst, 1); > > /* Disable the PLL lock-detect module */ > - if (MESON_PARM_APPLICABLE(&pll->l_detect)) > - meson_parm_write(clk->map, &pll->l_detect, 1); > + if (MESON_PARM_APPLICABLE(&pll->l_detect)) { > + if (pll->flags & CLK_MESON_PLL_L_DETECT_N) > + meson_parm_write(clk->map, &pll->l_detect, 1); > + else > + meson_parm_write(clk->map, &pll->l_detect, 0); > + } > > /* Enable the pll */ > meson_parm_write(clk->map, &pll->en, 1); > @@ -413,8 +417,12 @@ static int meson_clk_pll_enable(struct clk_hw *hw) > udelay(20); > > /* Enable the lock-detect module */ > - if (MESON_PARM_APPLICABLE(&pll->l_detect)) > - meson_parm_write(clk->map, &pll->l_detect, 0); > + if (MESON_PARM_APPLICABLE(&pll->l_detect)) { > + if (pll->flags & CLK_MESON_PLL_L_DETECT_N) > + meson_parm_write(clk->map, &pll->l_detect, 0); > + else > + meson_parm_write(clk->map, &pll->l_detect, 1); > + } > > if (meson_clk_pll_wait_lock(hw)) { > /* disable PLL when PLL lock failed. */ > diff --git a/drivers/clk/meson/clk-pll.h b/drivers/clk/meson/clk-pll.h > index 949157fb7bf5..83295a24721f 100644 > --- a/drivers/clk/meson/clk-pll.h > +++ b/drivers/clk/meson/clk-pll.h > @@ -29,6 +29,8 @@ struct pll_mult_range { > > #define CLK_MESON_PLL_ROUND_CLOSEST BIT(0) > #define CLK_MESON_PLL_NOINIT_ENABLED BIT(1) > +/* l_detect signal is active-low */ > +#define CLK_MESON_PLL_L_DETECT_N BIT(2) > > struct meson_clk_pll_data { > struct parm en; -- Jerome