From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98972C6FD19 for ; Mon, 13 Mar 2023 09:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ET+SAyODqR/7nZ+21RX0u/o4imMEtV4AoezQlxMwtxM=; b=XRc7rpB1Q4NtO/ MQ26hVWLbNuszPlxvtL6CQmEb+JN7D2zhXCYVWAGKmHIHxG+4fIAySabE4LTH0ZA8AfVn0oLVPM3O eSOMXIgGfVpsT08IoVJTzaBiH2geouHGn0yUPdxdoUDCpJ/ABTefgkarNN3ZbaBXnP1Rwaz+msqEr HG8emKJaz7+ku388FKzyFU8VM06F8fDOzRz/rhQWFotpcjDbqq+RKz5RpqeIXJQ3u8gC67bYGhfeD pYVkZ5WgcpsMAV7szdZwfLVL/6guM+WStds6vV1AbWKM69RUFCQF3a1lpMl1xsh5zINKijRCOhr5u cnbxI65WV62w2ZGRHk6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbeMm-004y5M-3P; Mon, 13 Mar 2023 09:21:16 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbeMg-004y2i-VG for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 09:21:13 +0000 Received: by mail-wm1-x333.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so10377928wmb.5 for ; Mon, 13 Mar 2023 02:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; t=1678699268; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=NyKmnb2IGGlRYKdA8v+Oi9cQGOt819vf2di9Hwq+CB0=; b=mSVsf+a/ifTL56wAV9Qw2FDlsV5LEVpddsOHAnmgmNWX8ZYxk80hyF4aQqagAEUpRc jDtW5tGU1a1sIXrahUuJD2t838vwVvvnj4Ixlt8aS35T1up5M9BaMB/TiJMSOI2IGuV9 4DpczCsw5ChdGLdIiV66BOPSrFanB1m6q32U2VqzOEmNpUIv9k55vB8EjTbMZCdowJuu /SVQvLaRF7kjaEKEuU54weShdspUHgoj7wr916M1wsEnxth4j2CBMJB6SrbWvLaot6br AjjW9ZVSxTuneR96w0vxXlzXrgJAt5qX1svj0H5QfW8P15XTzrOhQpO06GBAV80jJ6Q2 9YHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678699268; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NyKmnb2IGGlRYKdA8v+Oi9cQGOt819vf2di9Hwq+CB0=; b=a+XwZZw+5x4b+Q8+WNCWMrq5bBoNLw2u5jAYbBWJqXRCzg6RnAvTkJjHxeSbgVjFCI DEz4licFGaTAYcStvV6Cy1gC0VC6AiMArNWgQXFaqwzsPsa/lfEMFDWM+RJXVbMzHSWv MXq0popdxzbeMS6tgOhxi4btZa1NKllZUDaHjgWKjw1ZS3h2GWKPC6Qa+5m6ErrItU6m gvAHJ6I0OaOdZV3wLUIKNuCcd7H5gzKEXK4IQ2bb17XAN8hj27uHFPatJw0GcXn7UqlU r7hDPli+VtrhAGmCEM45mEwYW+oG0cKGFYX6mxUAQkD5KoT7UoINS9KK0XP28EYfHaLU Swjg== X-Gm-Message-State: AO0yUKV+b6WriqCIt3ceD+1eCC7kdQauF0zP3zg71gmX4SN7k0Ft1HcO tgUcasiNvfopYe8neo1JBwdHkg== X-Google-Smtp-Source: AK7set+ffANocDz449+nx/CU8mE/uaLR+A5C2On6Z7RmrE6Px8IYI5sqoAqzr08nkoqwgeu6K+3K2w== X-Received: by 2002:a05:600c:1c9a:b0:3ed:2418:6cbe with SMTP id k26-20020a05600c1c9a00b003ed24186cbemr2701778wms.39.1678699267735; Mon, 13 Mar 2023 02:21:07 -0700 (PDT) Received: from localhost (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.gmail.com with ESMTPSA id o4-20020a05600c378400b003e215a796fasm8292361wmr.34.2023.03.13.02.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 02:21:07 -0700 (PDT) References: <20230301183759.16163-1-ddrokosov@sberdevices.ru> <20230301183759.16163-3-ddrokosov@sberdevices.ru> <1jr0u2azfi.fsf@starbuckisacylon.baylibre.com> <20230306200549.7iuedbl27ejfhf6b@CAB-WSD-L081021> <1jlek60zun.fsf@starbuckisacylon.baylibre.com> <20230309182857.a2fzotcejueio23w@CAB-WSD-L081021> User-agent: mu4e 1.8.13; emacs 28.2 From: Jerome Brunet To: Dmitry Rokosov Cc: neil.armstrong@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com, martin.blumenstingl@googlemail.com, jian.hu@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v9 2/5] clk: meson: a1: add Amlogic A1 PLL clock controller driver Date: Mon, 13 Mar 2023 10:18:02 +0100 In-reply-to: <20230309182857.a2fzotcejueio23w@CAB-WSD-L081021> Message-ID: <1j5yb50zxz.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_022111_012846_3784B7E0 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 09 Mar 2023 at 21:28, Dmitry Rokosov wrote: >> >> >> >> This last poke should not bits otherwise handled by parms. >> >> This is a rate init in disguise. >> >> >> > >> > I believe, you are talking about hifi_pll clk_regmap conflicts with >> > hifi_init_regs. The above init sequence shouldn't affect pll regmap setup, >> > it doesn't touch them (we assume that default bit values are all zero): >> > >> > .en = { >> > .reg_off = ANACTRL_HIFIPLL_CTRL0, >> > .shift = 28, >> > .width = 1, >> > }, >> > // init_value = 0x01f18440 >> > // en_mask = 0x10000000 >> > >> > .m = { >> > .reg_off = ANACTRL_HIFIPLL_CTRL0, >> > .shift = 0, >> > .width = 8, >> > }, >> > // init_value = 0x01f18440 >> > // m_mask = 0x0000000f >> >> mask is 0xff with width 8 >> > > Ah, you're right. Anyway, I think this is just init value and it's okay > to set it during initialization and rewrite after in parameter > propagation stage. > ... But the magic pokes are there only to initialize the unmanaged part of the clock regs. I'd like it to be clear and stay that way. So please, clear the managed fields from the initial poke table. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel