From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE4E8C48260 for ; Tue, 13 Feb 2024 11:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9reGP9bmTcUG3oOTqESxwDlHCXAkg9dvkKsNCV/FpxE=; b=dNk7PwOlzWvMM9 NaNpbWu0fKY2OUaCkvKqc5Lco+y+GafH5lSOr9ukNjbrE9w/4/UZkrlHA5XABBJw6yQiy0vxlESm8 X0LeXWCkBbjldWeNV6vRw7GXEL5cFFXt+U/Lli72SkwChFT78Lj12JL56+s+gojEt5a7FYDeQYdrd EUWm4g6nWp7MAZksJ8M/zX2TLciTWPXgWVyANTlgoMnC0JuP5pO6bKYxzRI52DhQBxKdpOyGj+b36 DJEhzWwJsPC7bsm+b7afRQ6O5kzBqFf3IHF2dL5h+2bVvmittnfa1JJ5VSJRKTENE76bI1P07HbCt 0TWwhgM0MygrsdQjOn2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZrCJ-000000093yq-3RRh; Tue, 13 Feb 2024 11:43:35 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZrCG-000000093xl-0VVn for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 11:43:34 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3394bec856fso3106413f8f.0 for ; Tue, 13 Feb 2024 03:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1707824610; x=1708429410; darn=lists.infradead.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=E9Sow8wf4cLhsoNjPkxy+Vy7mK54b8EsDuIPycqqMjY=; b=ITnkOsB3SRXNc1+aaR1ETwGCNxBF1wpaBxRYVMpdhsldw7421XKcwZhdmUbOW+scbM ZdhOqIBQFv8qqlAXVcw3e2/BTHTJbp5DaibxzmDHL/MKCKQnG0rQX3L5ZhoEFULA2FQG +//T/G39bBDD6x1rms48pTPPcwgs2hnish9zkQYcqQbUxzYZS0+u73L+ht344220MkHp h+fyDXgnqkh1OkIm1POWlCk5G7Q37od1knUTwwSmmLq7f0DAciTL8p+m4Uv+0WrpPlf4 s52BC9F6irUtyejRWDmtkX9Fw81ZGOdnBISPou5YJuFLlvrTeDPRRLTgGrtZEY43nWMj OBvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707824610; x=1708429410; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E9Sow8wf4cLhsoNjPkxy+Vy7mK54b8EsDuIPycqqMjY=; b=smH3cJqcPsPsLI22kplb7TTP3Sfb+QPsi5A8gdfePmH7eqwYrPPBSFPCzRY4yPl7dq 2bU4tkB4CbNHYZhhwiGkg9RD2fWaTyWLPGGWNv6jsv8Coe7IpHif/13jtSkiiko1CfJ/ IfD9eLQgnu517IgDMKn8TOuVc4Zu4FJ1mvL/KEz5GBZ3qnkzs/2fU1eWyPY0tQQCk6af 3OnsfExPA/9iZaH9375uUaVZneV4NyCFHSvqK4YDkJvwXOFT3iGyyJSW7+y/GlZT1zni nXdvRHdatNu7YIYYx4SGkVQvp4W9I76nmictzSJjM8JDcfyoiUOiFOeBJlF4bjuvRhpI 48fQ== X-Forwarded-Encrypted: i=1; AJvYcCXI4QxeXsLMJXcmzlEVunckk68sL+Vdqe2tMBuAwTPop356TJY6QLk7LmfsXb0Jo5w0vcU2J2DM3ZujeWd94XAj4IVCsBoEdMkAeORimbTt6r8r0a4= X-Gm-Message-State: AOJu0YzNfWGIWaJEaeVL8vgzuGHor5ejZ2S8N+UIyVKyXptI2YvZuGpx 5XNCops0i7C0Sy9UkCfEHbmXgu7OwmDMpx1lzVuWbwY6gIDk7QGSWiaUaGzStGY= X-Google-Smtp-Source: AGHT+IG5/46zhd1eOGmh0ra4YTAm6cqkOsrOZ3nHpxyZmRoQkb4L9iG9KRCKL7XD6RvIzjKFdLIpsQ== X-Received: by 2002:adf:e501:0:b0:33c:ddf1:4e70 with SMTP id j1-20020adfe501000000b0033cddf14e70mr954874wrm.32.1707824610355; Tue, 13 Feb 2024 03:43:30 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV7XrcP98bixIaJaWBm55q3RGYgSAE7tBhAYxKCoTsFS3k+4Ze4N9ov5S7jgh/2kJS+irBO7hxgVQEv5sDqQLLxPDbHWC/Gs9TNJlYjDEdufmt8KqWgoLUap5P3RpuWSetm000MWsh8TG+RUnCiXYaeMS5P0KNR3vebzw4AK/Q7JSo2GChThL92QnUXlhhiqm3T+6Rm3bvBKFEBzRlNWsZ+oOtKvz4oZ5nrlk648f3KJ2YpB/AX8hYJ587hDFDHo7r1dZijD51CXUPKlm5Vvhyal5Vcu8pdKF6uRZUApCiCyWoYNna6+r1jeyiDnM+GrXyNfiI2jbQ39aZMPjTPS8Zd3pV6gPE6Q7iU5e+r5dq5ve8rVNhCu75nGRzfJSoMnFhhSRik6L03/9iH7StxCOiMjhlgvJXp0QLxcfnI7mQfyKBVWxmvK2n71BqvpzozyhkCuO8AO5J3tR81TAvxXYjA7ctciW/JxNy+0RD/Pu/DIgB3TrohH6Ieb4EtEjvFx//s0BbxRWmV5YdUNG0mEtgvFkabj7dgVuJmSkIyba37uRJ9Nj4vceMwV61cZXHq4Bloh/1m9MdaDSFr4L6+ysW0lgb2UhEH255fGSjDzoKUuGFhCI24w+H3rJL0zLOVpS/KYYbMSbqL1GxJsA+mmbtlzt0e6TZAQ/d1Iwa3 Received: from localhost ([2a01:e0a:3c5:5fb1:509b:4241:48a3:e3e0]) by smtp.gmail.com with ESMTPSA id m18-20020a5d56d2000000b0033b60bad2fcsm9261852wrw.113.2024.02.13.03.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:43:29 -0800 (PST) References: <20240213101220.459641-1-arnd@kernel.org> <1jbk8kk5pk.fsf@starbuckisacylon.baylibre.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Jerome Brunet To: Arnd Bergmann Cc: Jerome Brunet , Arnd Bergmann , Stephen Boyd , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] ASoC: meson: add helpers for clk_disable_unprepare Date: Tue, 13 Feb 2024 12:09:52 +0100 In-reply-to: Message-ID: <1j7cj8k2se.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_034332_336721_59073A1E X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 13 Feb 2024 at 11:52, "Arnd Bergmann" wrote: > On Tue, Feb 13, 2024, at 11:36, Jerome Brunet wrote: >> On Tue 13 Feb 2024 at 11:11, Arnd Bergmann wrote: > >> This probably pre-dates the introduction of devm_clk_get_enabled() >> It would probably be better to use that instead of duplicating helper >> functions which do the same thing. > > Ah, I had not thought of that interface either, so you are probably > right that this is the best way to do it. > Can you send a replacement patch then and add my Reported-by? Sure. How may I reproduce the problem ? Just tried with 'Debian clang version 16.0.6 (19)', no warning. I suppose I need to add something ? > > I also sent the same patch for drivers/nvmem/meson-efuse.c, which > I guess will also need the same treatment. I also checked and saw > that all three files already had this code in linux-6.0 when > devm_clk_get_enabled() got added. > >> If for any reason it is not possible, a common helper in clk.h would >> preferable I think. > > I can't think of anything that prevents us from using > devm_clk_get_enabled() here. > > Arnd -- Jerome _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel