From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 782A3C3271E for ; Mon, 8 Jul 2024 14:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HuWHS7n4JKE4Zhnq2fHCrq3JBbmX9LHIbWotNtCmupg=; b=xvdaR0Lolg6dIJ413Z+VP4TPld uDjGhWAhfMw+gF3ihYPenu2bgYLgr8c/arqmLQX4AjehAKo6PNZSaYPiHF0vrVBiiaWZvOVTUK8No uGBStXivNnQ4xu1sfX6BrS1Lobn5rpBssLiDGf2tZbZpbm/wYsbGdq/wGcybV0CGo9+hJ2MAS+NmT Kcs1hVSG1I6/SuG3Sg9TeUxUrg1Hd2/bGSnCx/+n5p1aj9NR5q69Uhvdfd2CSQB7I+Bc9L2wH1Gql fhBCqri7VRubnnGLU33NgbkZ+Oz0r9NzG3bk7YtExxq8VpFv8iKbWFeiDw46A+n9lyUFZZI1ysjcx H4ATCh2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQp9E-000000041wd-2Mou; Mon, 08 Jul 2024 14:15:20 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQo9B-00000003sfg-34pf for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2024 13:11:15 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-426636ef8c9so9716915e9.2 for ; Mon, 08 Jul 2024 06:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1720444271; x=1721049071; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HuWHS7n4JKE4Zhnq2fHCrq3JBbmX9LHIbWotNtCmupg=; b=hCOl1Fu6qGdQKrbnNglRGS8csMzW9TBEEEjTtPydZsvOgR4VU8x68L3HHFNRVl0tlZ 7jU75C4YDE+2uvigqCViDh8KlLoPtlOuNtsFJmKkk/vtQnafNFiO2crUz27t5yB47r1I 4ua6ObIyEkPEUzEOIEmmRTmsJATAxUq+axit5K68WD8dBJtD5Dfe0u0CkmLtg+HST9i8 e22qUNsJGdMOgshacd4UQ01L8ya4zcTA3K3JyR0iIuqAEEhCDegLBYcB+iGg5ehRsLrO ALbdbeCr37IdBthsa9KwXPc2xSTja0QaBc8czNgOOwNvLoqRIakRYDbf61JMI6ROg3oD UShw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720444271; x=1721049071; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HuWHS7n4JKE4Zhnq2fHCrq3JBbmX9LHIbWotNtCmupg=; b=cmU5TLjvDzHO7GaEWw7Jp2fcrbjy9slOdYOzWMTgyB6wEYxz/g8dkvwXCg9wUAJw5g aUYa6sbFJbb0dUowgtUXrXTIRH0ejsCi2VQ9wCtFoTLRbHupVOqXp1/3UIkBUIp9WJct B3jFYGeHtXCnfPwf0lIAAuRdQCXx+Rh9T0ztRHt8Y8v2qXiwxeJD3yANAoMvkYFV45G/ h+f+g5ZqgN0YjtDz5fQeRSePc0NLvUo7H369tSAXj9cxz9UE+mjYPvMXJPTTS6ow4GiG djGp9wlqPc4TdyZl/RbYMbfTjBJA/f9EeTYUt6VgUTZnhgY+ulqbwgqzY7FZ8rsCOhVf wVzg== X-Forwarded-Encrypted: i=1; AJvYcCUE1UBLzTa35caobt3MBu/qr6WaMxxX1c59IpTY4N3nPDnKCtAiO6TY2SDdD748kT55vaS8A5lYO2bay5OMgSeOtHHEvjyDYHfeHTr9RxxHzJLMso0= X-Gm-Message-State: AOJu0Yx/z+CsSGwAW2hIqOhjo3a2oTi4pq09cTRginXJFFkyX0/HspdL EMZpB5begDYVzX0sFhhA49knBe8Y4VbY5StamDUnejvF3QGLChLRnfzy1Dwm2DM= X-Google-Smtp-Source: AGHT+IG3y3s2abTIzMduavSusGk41h4eUyyiMJrCpnEXNNbVBBrdn+KPAsoARDJOB2DmaMtozMzthw== X-Received: by 2002:a05:600c:4da3:b0:426:6eac:8314 with SMTP id 5b1f17b1804b1-4266eac83bfmr5970605e9.1.1720444270774; Mon, 08 Jul 2024 06:11:10 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:5158:f510:c35c:9d0b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4264a21cb57sm163660395e9.21.2024.07.08.06.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 06:11:10 -0700 (PDT) From: Jerome Brunet To: George Stark Cc: , , , , , , , , , , , , , , Dmitry Rokosov Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 PWM In-Reply-To: <20240702123425.584610-2-gnstark@salutedevices.com> (George Stark's message of "Tue, 2 Jul 2024 15:34:24 +0300") References: <20240702123425.584610-1-gnstark@salutedevices.com> <20240702123425.584610-2-gnstark@salutedevices.com> Date: Mon, 08 Jul 2024 15:11:09 +0200 Message-ID: <1j8qychvv6.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_061113_898472_07A29D00 X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 02 Jul 2024 at 15:34, George Stark wrote: > The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. > > Signed-off-by: George Stark > Signed-off-by: Dmitry Rokosov > --- > .../devicetree/bindings/pwm/pwm-amlogic.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > index 1d71d4f8f328..e021cf59421a 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > @@ -37,6 +37,10 @@ properties: > - enum: > - amlogic,meson8-pwm-v2 > - amlogic,meson-s4-pwm > + - items: > + - enum: > + - amlogic,meson-a1-pwm > + - const: amlogic,meson-s4-pwm > - items: > - enum: > - amlogic,meson8b-pwm-v2 > @@ -56,6 +60,9 @@ properties: > minItems: 1 > maxItems: 2 > > + power-domains: > + maxItems: 1 > + The change is not only introducing a1 compatibility but also allowing a power-domain for the other SoC, even if optional. If that is intended, it should be stated in the description and probably a separate change. > "#pwm-cells": > const: 3 > > @@ -136,6 +143,16 @@ allOf: > required: > - clocks > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,meson-a1-pwm > + then: > + required: > + - power-domains > + > additionalProperties: false > > examples: -- Jerome