From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 317A0C04A68 for ; Thu, 28 Jul 2022 07:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:To:From:References:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Z0Td1MuqP1vBBtUkjf9TRDusagXSEE4ysTdeNBaZxo=; b=lK6juWliedZZTN bjy0ZgpLlKl+DUXhl7tk4pYj4i9VL3deilJwbX4YojfzWwGgRm40Skn9JTu8rf0e6e5EZVxeftIBx srQYeCRvvGmwdOMRH0ngoEgyCOb/Zy+P54Aq3WTpKdI2M9BoVWDm3VF5X7KCDALYsjDdEGpdc/GT8 cCWh9NeMct8HDNOu3D0TT2CkLJ7u/ZoDiVfXRmxCay3pbWPq+hTa7tI/f4mE2F7JXCjlrOmxRLnhh LrI5gicCy8dYKOZR/+E1AUULOjhleJj1RkMQT8cUaZNuFjZ+guA2zs3f5/zT7EuSxO+Ek2qCXVC09 QJVYdH6pyH/QVCvpPLoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGxk3-005Lyk-QQ; Thu, 28 Jul 2022 07:15:31 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGxjz-005Lvz-On for linux-arm-kernel@lists.infradead.org; Thu, 28 Jul 2022 07:15:30 +0000 Received: by mail-wm1-x32a.google.com with SMTP id n185so455458wmn.4 for ; Thu, 28 Jul 2022 00:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version; bh=AaIaSUDCvbW74aHuiO4CJrSTxDz4crTVOTtdXBqcE0U=; b=AWbcHHbX5voPsqXsYc0lPhQLZ7zq2Rbg+WDm4j47FHMHXMKBPLuAwqpaMLT4oN34qS R6hvle5W3TN4f3TJRhkhZx0QPFmqjX98W46tEqeGl2ss33pWsTUsz6ICWmUhi/rNGcp6 3eQgOfcF15Ov6JaO/BaW85eAfyYfbTZQOU7lHqyUe9RumDh0CPDhSAXX5tspMaURVBIN hAIUu2L93pP5MlYjVltII27G+d2lmMvuyd0SOq/7MlSZeJoZH16sIqKEMA/AAaXCwDjZ ZO3DlrFDankTYdhuu2q7oCaJtjXdqKBN2swatEdyWuhc0kJ1eFLYTZlGg6qxjCqabDjz qUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version; bh=AaIaSUDCvbW74aHuiO4CJrSTxDz4crTVOTtdXBqcE0U=; b=WaTSdntdcp0tgEzHeV46Oe2pjG6VJrf+TxtEGmZRfUS/ry1MyVr5KhSJAghQp+yibS +3kftj86InrayllzaVh2LipB4XcJhd0NaIqSaX6BSVljMT80PFK2g2WlouYm1us6fiIt d6QQ330P8LP/dBOpWhtxZIPccz2e1raM4KiZYnLoGzvbFfodNobYhJGS/jwsbPD9cowC c6vW+LmxVwxAcA/aU1LA7rW8PzOorCULgEMzIy0Gl0CkN7qbDOvz7cTA4g2GLNKyJCMs n1L6X9pwsUQaRIysD/1Zl4yPgPUurPD+JAmLVOHfMTE5CzrCIXYonZxD9Em2rO/KPC5u hI9w== X-Gm-Message-State: AJIora/osHioZLMupvB3OLikyNV5w1wfIqoPsAKcQV9JPmdo9hJWFAkV zWWiMaHmGMiQ4sCfqhBvR9LBXA== X-Google-Smtp-Source: AGRyM1uBQSHcp5qkcijv00Bu7Y7/z1KirWW8lPysYxj5MYnLBGbrvNTmEd6qDPwVfOty8mtSm4vSMw== X-Received: by 2002:a05:600c:1289:b0:3a4:8401:5ced with SMTP id t9-20020a05600c128900b003a484015cedmr384142wmd.148.1658992524267; Thu, 28 Jul 2022 00:15:24 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id n186-20020a1ca4c3000000b003a2d87aea57sm4519126wme.10.2022.07.28.00.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 00:15:23 -0700 (PDT) References: <20220728054202.6981-1-yu.tu@amlogic.com> User-agent: mu4e 1.8.6; emacs 27.1 From: Jerome Brunet To: Yu Tu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl Subject: Re: [PATCH V2 0/3] Add S4 SoC clock controller driver Date: Thu, 28 Jul 2022 09:08:44 +0200 In-reply-to: <20220728054202.6981-1-yu.tu@amlogic.com> Message-ID: <1j8rodhfn9.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220728_001527_811662_9A2941E0 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 28 Jul 2022 at 13:41, Yu Tu wrote: > 1. Add clock controller driver for S4 SOC. > > Yu Tu (3): > dt-bindings: clk: meson: add S4 SoC clock controller bindings > arm64: dts: meson: add S4 Soc clock controller in DT > clk: meson: s4: add s4 SoC clock controller driver > > V1 -> V2: Change format as discussed in the email. > > Link:https://lore.kernel.org/linux-amlogic/20220708062757.3662-1-yu.tu@amlogic.com/ > > .../bindings/clock/amlogic,gxbb-clkc.txt | 1 + > MAINTAINERS | 1 + > arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 11 + > drivers/clk/meson/Kconfig | 15 + > drivers/clk/meson/Makefile | 1 + > drivers/clk/meson/s4.c | 4732 +++++++++++++++++ > drivers/clk/meson/s4.h | 296 ++ > include/dt-bindings/clock/s4-clkc.h | 146 + > 8 files changed, 5203 insertions(+) > create mode 100644 drivers/clk/meson/s4.c > create mode 100644 drivers/clk/meson/s4.h > create mode 100644 include/dt-bindings/clock/s4-clkc.h > > > base-commit: b293bc9286ee21824e93f0fcfed3b78fdfee01e6 Please don't post until you have addressed *ALL* the comments from the previous version. At first glance, I can see that this is still a single driver for what is obviously 2 controllers with 2 register spaces. Simple comments like the "<< 2" in the register declaration have not been addressed either. Seeing that, I have not reviewed this version further. I won't until all the comments from v1 are either addressed or answered. Regards Jerome _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel