From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14E0FC433EF for ; Wed, 6 Jul 2022 13:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AHpCkosEttgTZDgMGG+U/VJdg8VjyrYz8+RKL1YkVX0=; b=XLtzWlI0JdEdmI bRuy1hoLcsKNCPQzTzFjOq8pOicBb+4EhqYBGEe636pFwbaAKYEe35z6BMwnrOBMQg2BuV2n7WbxW D2W5mIHYpoKW7Lu6986y83+/EB8xRtS2cvrA2CkusVbwXsw7RP98tlKWpX4QomU0ma+XfsYZbj6j4 G4EoOu+JL66GuJQGr00zL2eVs1WP2Bx6zVtH4/PUKSbtaMAp9NdYWrF9hGP1JUPzb+AKE30VLZz2J BdkTWB/6jP9JjYKDDoh4tpZSFYV2RwoTvEzBlasVXzVItMFXhE3gYktoG/tYMLbEOvR+shlVxtfD9 M9TC62L7nbNanlhijhrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95Nn-00APEF-W1; Wed, 06 Jul 2022 13:48:00 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95Ni-00APAJ-QN for linux-arm-kernel@lists.infradead.org; Wed, 06 Jul 2022 13:47:57 +0000 Received: by mail-wm1-x32e.google.com with SMTP id l68so8863608wml.3 for ; Wed, 06 Jul 2022 06:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=oUwD/AXk3hn18jg9g8hVaPoJbhZdU+eC6asfRcw/JZ8=; b=OV6NQ+wPRl2SEbWwcpJRPhyEuZ8cg8yTsJqgVyKnZOK2UthzIAwcDwB3+WLL18sjlb /C16E768PD8WDWQUV6iOuuogcZaJTm3BQQsDxPgatCYJKd+jgAHy1Tif+KBTazTMIlG/ kxGvrZ0Tvh2dHNnjY8fuDHaK5o5kkwzA5t881UFs5Y/G0C1qj/QbDh/lehUdLme1OnUm YpZ2RKUuGtPpgDS7hss+aISwdPO9egSp90BXGcvs1tYhm0cVrJ80C2ATmvjFYErITX1w ajhAeUc+2+ukI2+7/Coim6NfRFcDUpiexL3hP8VSfhXG28L4D0jNDHs4VXRANYAZ2PQm L6MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=oUwD/AXk3hn18jg9g8hVaPoJbhZdU+eC6asfRcw/JZ8=; b=hj7jgQtjJNncQI8+pW7Ji403ExKOg7vVfEzYxxfqR/PvsGwy6VPmZWfnChEjLEh2dh 6RqQd30jz4s4qmy7XozRHEh+BZEiAhfIdjOv674M//iY6yrSAvqIUTxWaPMsur00tOf4 7lUJ6WnnqANLqAYV6miDw6LkP9tGJE29VZjkoAbrvmjQZWw4FwxzRDtqL+zo1UoE0vD2 +As3G2RHoLUzyHQKdKKWo+Fc6rhTVrh9QxSSdtLYCyyJPyKbvhy/8zILm1Ng8ZqMwUQU 5EzSjKc4grnWCJIxBifmuT746+WXh8k1ZFa0I9RPTx8gyjDQBRpqR3s48elyjexRP5f2 e2sw== X-Gm-Message-State: AJIora8nYwm892EFwg0iG5xWjGxtg/TMbmlk2VwvcqSntRecLy+Oy32z lYHvMPBehfN09KxQ7JIQO6msSQ== X-Google-Smtp-Source: AGRyM1uUD5fUICbLUxi3NjNN7CjKDLK0xdLSPc5G0890T3qq/ARu1rv+irGhKla3vDPUN0DyFqatKQ== X-Received: by 2002:a7b:c413:0:b0:3a1:8f03:29d0 with SMTP id k19-20020a7bc413000000b003a18f0329d0mr29344119wmi.160.1657115273408; Wed, 06 Jul 2022 06:47:53 -0700 (PDT) Received: from localhost (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.gmail.com with ESMTPSA id v192-20020a1cacc9000000b003975c7058bfsm26068541wme.12.2022.07.06.06.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 06:47:53 -0700 (PDT) References: <20220705142444.17063-1-pboos@baylibre.com> <1jmtdnwd7y.fsf@starbuckisacylon.baylibre.com> <20220706124139.GB492220@roeck-us.net> User-agent: mu4e 1.8.3; emacs 27.1 From: Jerome Brunet To: Guenter Roeck Cc: Jerome Brunet , Neil Armstrong , Philippe Boos , Wim Van Sebroeck , Kevin Hilman , Martin Blumenstingl , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] watchdog: meson: keep running if already active Date: Wed, 06 Jul 2022 15:24:27 +0200 In-reply-to: <20220706124139.GB492220@roeck-us.net> Message-ID: <1j8rp6z720.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_064755_082707_EEACF098 X-CRM114-Status: GOOD ( 25.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 06 Jul 2022 at 05:41, Guenter Roeck wrote: > On Tue, Jul 05, 2022 at 09:29:35PM +0200, Jerome Brunet wrote: >> >> On Tue 05 Jul 2022 at 16:39, Neil Armstrong wrote: >> >> > Hi, >> > >> > On 05/07/2022 16:24, Philippe Boos wrote: >> >> If the watchdog is already running (e.g.: started by bootloader) then >> >> the kernel driver should keep the watchdog active but the amlogic driver >> >> turns it off. >> >> Let the driver fix the clock rate then restart the watchdog if it was >> >> previously active. >> >> Reviewed-by: Jerome Brunet >> > >> > Please drop this review tag since it was done off-list >> >> Indeed a review was done off-list. >> >> Reviewed-by says a review has been done. I was not aware this applied to >> public reviews only. I probably missed that, would you mind pointing me >> to that rule please ? >> > > Public or not doesn't really matter. However, you can only apply a > Reviewed-by: tag (or any tag, really) if you explicitly received one. > The exchange seems to suggest that you did not receive that tag. Philippe did receive that Reviewed-by. I gave it to him. Doing his first public patches, he first requested a review off-list to try to get things right and not bother people too much (so much for that :/) > Please never add any tags on your own. He did not. > > On the other side, if the reviewer did send a Reviewed-by: tag off list, > I would kindly ask the reviewer to not do that in the future to avoid > misunderstandings. No worries. That being said, I have gone over https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst It just says that Reviewed-by sent on the list should be collected for the following version. Nothing against adding the tag if the job has been done, on or off list. Same goes for Suggested-by, Tested-by, etc. If I missed something or it is non-written rule, please let me know. > If you don't want your Reviewed-by: tag attached to > a patch, don't send one. Not everyone will even realize that you sent > your tag off-list, and no one can be expected to know that you didn't > really mean it when you sent your tag. I do want Philippe to add it. I would not have given it the first place if it was not the case. > > Thanks, > Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel