From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10C1CCD98D2 for ; Thu, 11 Jun 2026 08:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q+GZxQR0zVGYyc7t6dGL8c2RABIohdt9U+GPG+DCKw4=; b=s5eKW8Cl9JqZypMExlyypEPqAE cEUOokGZoszuv5sZ2IAtnuhFURND+sbtw7ae/NmfpZG3WCNDos8r+a6qIpw6y863S9/83MaXjLa3I AvS2LUJSd9qjb4hnqo2hk0N+JcopmUTQHtQmguMlt4rIUsC0X67149LsG3QCs8SP6juwc7rTd3XIy XlBin5yVJrVNEq5Wu70roXZ9hY1zHFGLc7Fe7PASOup7Mdrw2o91e16Mi6xorBdxbTGGKJqmiIDRR G/GUGbKfZucUUgMEKzVV0DyCtdJUGP3/ik631417Q25qoBMungF/W+UOjB5+NJz7mLaLChULIUvgF Rt5HSZyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXama-000000090t7-19hU; Thu, 11 Jun 2026 08:29:00 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXamX-000000090sJ-1TGj for linux-arm-kernel@lists.infradead.org; Thu, 11 Jun 2026 08:28:59 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-45eeea039ebso4129369f8f.1 for ; Thu, 11 Jun 2026 01:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781166535; x=1781771335; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=q+GZxQR0zVGYyc7t6dGL8c2RABIohdt9U+GPG+DCKw4=; b=Y1Xv+SaJ+nHtHpAVwu9s3AlGb4ludH3gsHZ3LMJzBja8qJGs+m8vXUdR1OZ6+3Pt9e 7smCMcxXU6gSGNypibXl1yB1jGVswJMSYNIN+aCm/qYjWB1G0jHym/rRxWIiOcQEC4VI QpOCYUu4qoVGAbrmMHVx+X8oLDFcnIV/SZoZK69LHoh7aFQHY3llc1Ii2rhj8yWyBThA AKrPRkDI1oAvZ53QgVuY+rFZ/VSMtk+XMTTyLiasdiWPStAmcveyCfbFLswlWHMjxBit A4FsoIpuvM4scYXYt/HOJrRgcaqb0Fm1P+MH4BgjqSdYCGicOchRsmvyJc6zn0pP1CXw xbHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781166535; x=1781771335; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=q+GZxQR0zVGYyc7t6dGL8c2RABIohdt9U+GPG+DCKw4=; b=S5RiUb0iGiLpk6haNJuS43Jm28D4Z2G0VviqAbhqSu99aDw22pR3fkLpPZxwxnj1Xl kMackpyv8oc5YSxS0dGT5t4sCgIsyZ2cQGLMsKBmmElwdp+9/sDqyguqFZWq1x+6Q6dW hDOqCrHa9tDVmjP9elsnIwYPQHXN52qDbESslvi9PMSPrIs4wXYMRy8tg6vkgq3ZlCZU ToGL6Z3V5OmBHXoQc5zZ5tF9QlMZC5tOACohmcMZrRdumo+5881W+0t+iYN+850eJQdF c0xLxhG2PPakvsEdDGE7oQCkVpuUKUkfvA4gxmohNczE3+tM/8wv/9VMPKxeSLYR4TnE MgXg== X-Forwarded-Encrypted: i=1; AFNElJ8ENHuSzsPGOalhFK2d4ezf1WUytp6HWq9plwAJVsMEDyy/2G1Zecb8M/y8uMSgQ2JP0Tep0YQeB2Etj6Vd5Zz8@lists.infradead.org X-Gm-Message-State: AOJu0YzxNZVdD14GGdkPm6eC1se7S5MjHb0cIuO/yl+8EJ4UFjTAImbn Ng7C9Qi6a0SS4MKnFtkFlv9ovbx3GRDstyl515cgdFXxLDsajO+btSDyypishvsDYiM= X-Gm-Gg: Acq92OHYN30SKgcHlcikKSXqdkuOQP7Bk82cTB6NENhaoL18lRUj2w9MjkBxtKgzGYh y30L01HS8sHJIjqWXspfV5cN5xvi/b0Hj0MO7gvcyDYFNhOKojVSn4htxTGZTpyZl08dJBPnyws CR4x7w7fqVeIZ7GW5Ez6Kh4q+T8tSNQV6MgAQFUlBIMdzueFIhtfcnwo9qabLGhrGWf5L8gZd1+ XmpQPGj2ySkK2EvNoNYRiGAaL5zuUm3320p0TUGMVGy9PFSnIWKRzrEd8OOzsrw0sFCNY1fwqio w2aHvbcFZYo5uN0mShonKFv+th127gLJQnlxkZdMrDqWpRO+N31x3HoaXaElFYmWs+kktuaqFB3 e30evHQWcmryZoav3B91JYHTgGLDD28OVkTOJHGul/2P/vRvIGa0oS7p0k2JtDHrJyfi6mxNXVo jVndsKjJ/xijMeHaGy+yTgn4awGU9+cRIL X-Received: by 2002:a05:600d:8450:10b0:48e:6db3:ff2e with SMTP id 5b1f17b1804b1-490e55dd891mr14395135e9.15.1781166535248; Thu, 11 Jun 2026 01:28:55 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:1d1b:88ba:5161:3581]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f35133csm75931032f8f.25.2026.06.11.01.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 01:28:54 -0700 (PDT) From: Jerome Brunet To: Valerio Setti Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH v2 0/4] ASoC: meson: aiu: align I2S design to the AXG one In-Reply-To: <20260610-reshape-aiu-as-axg-v2-0-cac3663a8b51@baylibre.com> (Valerio Setti's message of "Wed, 10 Jun 2026 23:29:24 +0200") References: <20260610-reshape-aiu-as-axg-v2-0-cac3663a8b51@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 11 Jun 2026 10:28:53 +0200 Message-ID: <1jcxxxeb0a.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260611_012857_432600_7BFB0A73 X-CRM114-Status: GOOD ( 21.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On mer. 10 juin 2026 at 23:29, Valerio Setti wrote: > The goal of this series is to reshape Amlogic GX's AIU implementation for > I2S to let it follow the same design as in AXG's TDM. Keeping the same > design allows for unifying the two platform implementations in the future > and it also allows for an easy addition of I2S input. > > The first commit introduces gx-formatter as the basic block which takes > care of properly formatting audio data. Formatters are DAPM widgets > (c.f. axg-tdm-formatter in AXG) which are dynamically attached/detached > to the streams when the latters starts/stop, respectively. > aiu-formatter-i2s is introduced as formatter implementation for the i2s > output. > > By the end aiu-encoder-i2s will only need to handle interface clocks and > enforce interface wide rate symmetry (c.f axg-tdm-interface on the AXG > platform). Right now rate symmetry is not relevant because only i2s output > is supported, but it will become useful when following patch series will > introduce the i2s input part. > > This series was tested on an OdroidC2 board (Amlogic S905 SOC) both with > HDMI output and with NXP SGTL5000 codec connected to the I2S pins. > This series was also verified using "pcm-test" test tool and all tests > are passing. > > Changes in v2: > - Fixed most of the weaknesses found by Sashiko review tool [1]. > - Resolved testing failures with "pcm-test" as reported by Mark Brown > (thanks for the heads up!). I left a comment in > "aiu_encoder_i2s_startup" to explain the fix. > > Link to v1: https://lore.kernel.org/r/20260515-reshape-aiu-as-axg-v1-0-53b457784ff3@baylibre.com > > [1]: https://sashiko.dev/#/patchset/20260515-reshape-aiu-as-axg-v1-0-53b457784ff3%40baylibre.com > > Signed-off-by: Valerio Setti Nice work. Thanks for taking the time to understand the existing drivers and build upon them ! Reviewed-by: Jerome Brunet Feel free to add yourself as maintainer of the Amlogic audio drivers, if you fancy doing so ;) > --- > Valerio Setti (4): > ASoC: meson: gx: add gx-formatter and gx-interface > ASoC: meson: aiu-encoder-i2s: prepare for multiple streams > ASoC: meson: aiu: introduce I2S output formatter > ASoC: meson: aiu: use aiu-formatter-i2s to format I2S output data > > sound/soc/meson/Makefile | 2 + > sound/soc/meson/aiu-encoder-i2s.c | 281 +++++++++++++++++++++++++---------- > sound/soc/meson/aiu-formatter-i2s.c | 104 +++++++++++++ > sound/soc/meson/aiu.c | 32 +++- > sound/soc/meson/aiu.h | 4 + > sound/soc/meson/gx-formatter.c | 282 ++++++++++++++++++++++++++++++++++++ > sound/soc/meson/gx-formatter.h | 56 +++++++ > sound/soc/meson/gx-interface.h | 48 ++++++ > 8 files changed, 731 insertions(+), 78 deletions(-) > --- > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > change-id: 20260515-reshape-aiu-as-axg-1dac9037cad3 > > Best regards, -- Jerome