From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A50F7C44500 for ; Fri, 3 Jul 2026 07:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Zqjm78soCzOZsah5k4plTO+J9DTAjqlcZkOG5zlqAcQ=; b=3kzgfWWHnPZSjT+r882g9LHLQC ZqvJrPRA9rCsNRi7vSDz063ONV/5sxgEG/EWqktoIqWtXxB//kXeDyA1gPQRSUfcvPSzYmBlj/zj5 W7qKRaYhMjaLJbE3l5Typ46Pzjfxueb8G2EqzWxLrc/cSMrwvBHLhnZ2ioTosaX6+0oQvry80WLyX kHCD9hx97SMsKXKlmfRBT8hXE8VmogEm7CB+wWRaxm0xw/LpYD2GJHI6dSmjcWphgk/iV23umAPA2 pYO/jKe0dmphLMSG2W3R0T+fY3t8FMXyxsvtUt42uBfkvprmObZkoi+s7SddOLiSDnsC3BY7SdUvQ jjYqKrkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfYni-00000006Jat-470U; Fri, 03 Jul 2026 07:59:06 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfYnf-00000006JZs-1dAO for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2026 07:59:05 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-4728c12ba97so159932f8f.0 for ; Fri, 03 Jul 2026 00:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783065541; x=1783670341; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zqjm78soCzOZsah5k4plTO+J9DTAjqlcZkOG5zlqAcQ=; b=ib1ojA3Zq3p1kCf6DhsmsWgBg7mltB4hHpgRL+M+gbmVv81isHbn2ul/BOLqUofy2+ 4S+iSjXcP2X/lk4ZSs/jFOhOfT2uXkzS9icJ5V7zgc1hIefuUo1LKjzGB+GirsiuCKhz 4LmMH7QosWrT6/eRLkNltS/LpkKyM86665ub28h59d5tTKawi3F/KtY2KpqEf2J7JjPj T+HLe5pnxoX18yjp9A1VV4FhH0XLNNjt8WxPJ9+17ZTlBckmKJ4gXr3q8FRowNs6g+01 b40hKw2dYCIzDAozgHapxu+lVxWU/ArsjUYxvv5Qey3g4m8TcNqUqHqtatRM+B0MytWu wOUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783065541; x=1783670341; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Zqjm78soCzOZsah5k4plTO+J9DTAjqlcZkOG5zlqAcQ=; b=VkZ5ch50HXAyica9t165kKKHWTPA2BZc7Mf+DKvJ4dgIK7I4iL8M1hRcLE/b7fXNjC nZ7BqtCbD73brXJ51scHZS+vvkxPQOM4w9CW9xM7zzOWsV9Tyjr93wLxymDCv8oPXMQ3 kE0Q2iTEllfHXKStLPT5m4nZBssTRNI4Sdg05MrJX++ckwM2TsYz9ethZ8t2Knoaucfa VZkfqfWYY7VC9P+74b/yDRQLZenjLydudnMf3t4HaRI7jnBECAni3GEH/4zUKc8dMHxT bIiT5kdEsEWkCM7p9Aqqj5CL12vk4RrPwrDd/qhiO6UHkKZJA2I3VIWvNRz0qk4e/Mxu 6+jg== X-Forwarded-Encrypted: i=1; AHgh+RoLYzYLqWuSXpZuZPI8oFqb5RZn6teX99BsXxGVQfRFVGdGyVvTYGjoEURJo4WQSDcY7Qh6Tc9acve6ycaj55JG@lists.infradead.org X-Gm-Message-State: AOJu0YzDafLfuel9xnXApFRpNl7fK2LLTK0h9qUC55u0BqQezakVJ2aL k6ZKaLVuEp0Z64QTaDZEjv4COxDPvnLXeyeCUyAplJkCwatQ7L3cY1jt+djz1YKzeFI= X-Gm-Gg: AfdE7cmO1qCdd43IoUmOqyihlJDfARng14gwfnCXoPFuMc6O/1O/EzYqH47Y9w5YI25 pEPATZHroFEnvNfFRe9lWQGYOoPQfrrFLZfpM5mgIJ7/U0E9ruqS9SavTTCtsZQk7kvDZNshbH2 kC6IULHMNHg87asdX53IcVEJOwxFvX8kOhCs/AZQImtmMHRfKEiiLYPv5eS28yOJLvs7de7LD7G NWcfQneF4AjatxwPjDMtnLrXeiaHBbcDlvIIPqvFk708p12USM8XxIbLmfVoslfFck4SreXbfwl pNcC/E808QURgKpk+kZUZz0M0d7k6jOJB9kp2WzKsNlyDg++1DmRGpgSiHjmXXImBHsK1ZrK25W N0DEwEumpH1AsCoc/GVqmRU9/pISqfV8hS4Hk82laLdP6p3dAMFvH0IQlDQLo9TCpHoj+pypN8E T+FA9/es2Cz4rxBhh33Arp2A== X-Received: by 2002:a05:6000:2310:b0:46f:e796:c3fc with SMTP id ffacd0b85a97d-47757c6d1e4mr14250190f8f.25.1783065541604; Fri, 03 Jul 2026 00:59:01 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:fb6a:cb8b:b7f7:bb42]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-477dde19fd3sm16565369f8f.25.2026.07.03.00.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 00:59:00 -0700 (PDT) From: Jerome Brunet To: Valerio Setti Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: meson: aiu-formatter: remove pipeline reset from prepare In-Reply-To: <20260702-fix-24-bit-i2s-playback-v1-2-bcd3a43fe32a@baylibre.com> (Valerio Setti's message of "Thu, 02 Jul 2026 12:56:41 +0200") References: <20260702-fix-24-bit-i2s-playback-v1-0-bcd3a43fe32a@baylibre.com> <20260702-fix-24-bit-i2s-playback-v1-2-bcd3a43fe32a@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Fri, 03 Jul 2026 09:58:59 +0200 Message-ID: <1jfr20ijwc.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260703_005903_439663_4B8AEC2A X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On jeu. 02 juil. 2026 at 12:56, Valerio Setti wrote: > 'aiu-formatter-i2s' already performs the very same reset in > 'aiu_fifo_i2s_trigger' for all relevant trigger scenarios. There is no > need to duplicate the operation in the formatter. > > Signed-off-by: Valerio Setti Reviewed-by: Jerome Brunet > --- > sound/soc/meson/aiu-formatter-i2s.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/meson/aiu-formatter-i2s.c b/sound/soc/meson/aiu-formatter-i2s.c > index b4604734fe88..cb554c2e7ce4 100644 > --- a/sound/soc/meson/aiu-formatter-i2s.c > +++ b/sound/soc/meson/aiu-formatter-i2s.c > @@ -13,7 +13,6 @@ > #define AIU_I2S_SOURCE_DESC_MODE_8CH BIT(0) > #define AIU_I2S_SOURCE_DESC_MODE_24BIT BIT(5) > #define AIU_I2S_SOURCE_DESC_MODE_32BIT BIT(9) > -#define AIU_RST_SOFT_I2S_FAST BIT(0) > > #define AIU_I2S_DAC_CFG_MSB_FIRST BIT(2) > > @@ -55,11 +54,11 @@ static int aiu_formatter_i2s_prepare(struct regmap *map, > { > /* Always operate in split (classic interleaved) mode */ > unsigned int desc = 0; > - unsigned int tmp; > > - /* Reset required to update the pipeline */ > - regmap_write(map, AIU_RST_SOFT, AIU_RST_SOFT_I2S_FAST); > - regmap_read(map, AIU_I2S_SYNC, &tmp); > + /* > + * Pipeline reset is already implemented in aiu_fifo_i2s_trigger() at > + * trigger time. > + */ > > switch (ts->physical_width) { > case 16: /* Nothing to do */ -- Jerome