From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44AA5D2FFE0 for ; Fri, 18 Oct 2024 09:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/6CJlVFCdkLnXR5mIG5TznNaMuOGXx1zBL9Ig1xKknA=; b=kaI1MHaFZ7YCGqIAf/1M7p6hG0 tk/fOytOAwdmaYXLQm+lkuIJke+2dN0cfxv1pFI/pgJVPT1WnXBqAGdxYA+DX85qes41SnPKUEdJn qR9u9IYZo47nuHDwv+8MoeaY2D/yysM2RFZwgJPifnyYEKacDQkZHKXzWbNVwvGXgGwQdrC3hPa5w vhBY5FpSgrsGhmRzjBsss+m5r0esWdHIZc1OThoSWvTAivmVlxYAEUImUOFb/FMm+g0WoWUyBHAR/ uM8PLWLrccJr/C8S78wpXDabT9TxqYMZOkxV6863o/3OfOc1kk6BU/Lh+NWHeU85yKQfSuNdZNg5Q D+0q9gxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1jJ9-00000000CFe-31Eb; Fri, 18 Oct 2024 09:30:07 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1jAL-00000000Adi-3UIU for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 09:21:04 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-37d518f9abcso1374574f8f.2 for ; Fri, 18 Oct 2024 02:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729243260; x=1729848060; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/6CJlVFCdkLnXR5mIG5TznNaMuOGXx1zBL9Ig1xKknA=; b=Hvam9pxXx2LcQ+v4LMLYf6+Zi8pmNXkjzesQM66yqZuZ6Y6VmOrJLNDP2EMejrf+VZ lx+XWHuHEG3OgaSdbiW6Hpq0uVHz44kP49nIrHCiXojn8ECVj02R2sRmXrejHnG4L64A cdEsFShMgL/85K8tnorpsKbSuykbeFW4zzv+fCA65wga7bqck2zee/cyR5aBK9o4St6h Q9uhGVamEFmGgPpahACy/0S+TAkScr+Un6P6AreuxTGVe7DQRXYILrMFBHQJq8roSXBN U3FOuKqjQeUTBQ8ha0vV4dp56uQgf4WbAYCOEd9hZ0ZOJcZvCJMEiDBWBRcFtbfVCty3 M5bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729243260; x=1729848060; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/6CJlVFCdkLnXR5mIG5TznNaMuOGXx1zBL9Ig1xKknA=; b=ZlaBzeuRJ9MlP/Ryf91joQi0I3VuUFOPwbYr7AvnmUFpbaIKP4WtEtgofIN9oXY2rw lTgNr7c7deXq77Ja4fzfeMPclbsqF9mjF6Yo+1+8u3WRN3RMWYtQLsxS4Dzx/NbwbKB7 6BKs6Qx2zJ7zW2brEKUR0J0ZEbwAxp27YLR8SwEVTZYB02H2gcltIhQmkgqaDa7NWxWA FCB+pQEJdZgUtX8pMs33Ss0xlPOMMK32NrC+IRJh7NFaGHb8mvtqYJFKxefsF33ixIhL 6FN7rrwzZTlRz1BKyh7q5wn+vz/wrjsh56wKccfI1zElamsQE12JM2XlGVfGASMusJsI 6UaA== X-Forwarded-Encrypted: i=1; AJvYcCUY2vPNzIDzP149YLtKU5/zbTEjkPEEcOX4OUFiLHMpjR1gEXyiksFKnyzgYWEBIEvEkwrgOAueQCUfMV88StbF@lists.infradead.org X-Gm-Message-State: AOJu0Yz3R4Q8NYDoPW0QP8Y/4pIPe8mExHTtxfrreIbha0VZJfSk1pHy yUz3L6zGaf3iodQV7WhVtckw7SZXa0fpauTVeD0NWNI41fNx9n7eO/J7oaSGl5E= X-Google-Smtp-Source: AGHT+IEjc8x6P1fiXZXvuy0RRWf3NASza2rMgKQJv+Xo7tziKvwCXEKE7ppPcNk2dKWu+ZlA7d9gqg== X-Received: by 2002:adf:9bce:0:b0:374:c3e4:d6de with SMTP id ffacd0b85a97d-37eb47693ebmr1176601f8f.41.1729243259689; Fri, 18 Oct 2024 02:20:59 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:6e2b:4562:2d66:575e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ecf0eccbasm1390562f8f.81.2024.10.18.02.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 02:20:59 -0700 (PDT) From: Jerome Brunet To: Xianwei Zhao Cc: Krzysztof Kozlowski , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Amlogic A4 SoCs In-Reply-To: <4127b448-a914-4c69-b938-29512995326f@amlogic.com> (Xianwei Zhao's message of "Fri, 18 Oct 2024 17:01:09 +0800") References: <20241018-a4_pinctrl-v3-0-e76fd1cf01d7@amlogic.com> <20241018-a4_pinctrl-v3-1-e76fd1cf01d7@amlogic.com> <4a79f996-9d82-48b2-8a93-d7917413ed8c@kernel.org> <1jttd9rein.fsf@starbuckisacylon.baylibre.com> <4127b448-a914-4c69-b938-29512995326f@amlogic.com> Date: Fri, 18 Oct 2024 11:20:58 +0200 Message-ID: <1jmsj1rclh.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_022101_902733_12B1B873 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 18 Oct 2024 at 17:01, Xianwei Zhao wrote: > Hi Jerome, > Thanks for your reply. > > On 2024/10/18 16:39, Jerome Brunet wrote: >> [ EXTERNAL EMAIL ] >> On Fri 18 Oct 2024 at 10:28, Krzysztof Kozlowski wrote: >> >>> On 18/10/2024 10:10, Xianwei Zhao via B4 Relay wrote: >>>> From: Xianwei Zhao >>>> >>>> Add the new compatible name for Amlogic A4 pin controller, and add >>>> a new dt-binding header file which document the detail pin names. >> the change does not do what is described here. At least the description >> needs updating. >> > > Will do. > >> So if the pin definition is now in the driver, does it mean that pins have >> to be referenced in DT directly using the made up numbers that are >> created in pinctrl-amlogic-a4.c at the beginning of patch #2 ? >> > > Yes. > >> If that's case, it does not look very easy a read. >> > > It does happen. The pin definition does not fall under the category of > binding. > > https://lore.kernel.org/all/106f4321-59e8-49b9-bad3-eeb57627c921@amlogic.com/ So the expectation is that people will write something like: reset-gpios = <&gpio 42 GPIO_ACTIVE_LOW>; And others will go in the driver to see that is maps to GPIOX_10 ? the number being completly made up, with no link to anything HW/Datasheet whatsoever ? This is how things should be done now ? > >>>> >>>> Signed-off-by: Xianwei Zhao >>> >>> Acked-by: Krzysztof Kozlowski >>> >>> Best regards, >>> Krzysztof >> -- >> Jerome -- Jerome