From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C63D9C67861 for ; Mon, 8 Apr 2024 18:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ikmEZlPlIP+a2kgZI2dTYI4jAaxpAUi+ziWJbbjyb7U=; b=W1XEVpENLvlcmb hgqALFxcyyyD54MW8f6OjSMj6K9Is1aD50A6b7Sc/Yvh+IyG+hejoywuQRNQyNIVpYcbJcea3pRF6 nQJK+UfV3yXx49FyEdwGc9HPFMeKfB8XhYPIuVgNygnfGvLNt9Uh40O8s1LOODysypm/IOxtWnl+c wa9SXD8rg1haArtyz7AQ3MfjWkSDapN4w/EdvDFx0P9c4w+SUhio5SYFiwIVHm1sB31ykD0bZBsus Q906EbdhDGo8LCG3FwLKEV3coZY1wG+c16C5HCcfFLmP3uQb20KLvSa59qhJIWQTqciH9eLBSxz4A LY8Piw6Yp0bdtkjM/now==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtu3A-0000000GY5o-1cGE; Mon, 08 Apr 2024 18:49:00 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtu37-0000000GY4p-2Amw for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 18:48:58 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-416a0878ad9so142295e9.3 for ; Mon, 08 Apr 2024 11:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1712602135; x=1713206935; darn=lists.infradead.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=/5O9U718NHGvhBsjamAS1sHo9zrNE6S5TEc1aVEiLaU=; b=dDtttQCnu8VS0zHyHH5xK2RjPgu1/Rq1RwgOUuj511lGL7HYjBjDcXr6CkX7SuC3kz pjtD9xIitQ4tXEvypkCXOyYMmLPIr/KEV/1S6+1b7L2M+LsID2bCInUCkKdb3IPdEUXS 968oFCnEiPJNM6cITASaqBKsrstWCrKn5Vbp4E/lPq8z1mifXZ4wlNehtBh9sw4sWjSP GYIJZzeKq/DhTyJNsIPEmbj5jjsh1Bc6BiNOJhWTvlvQgqzhcvZGwgvhI+3vXJFGlewz u8XCWHNIu+Sr89n46JhmLoolO28nvU4iECd2tk0Gv+8dNTlhEzMZMh526M/ICoPlxyFx ZvTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712602135; x=1713206935; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/5O9U718NHGvhBsjamAS1sHo9zrNE6S5TEc1aVEiLaU=; b=oHZUS68ml5zhCMEv+kWFNfey6cVXa4G+llPTbOgQsb+nEEgiAHZOevdAaq42waVxW1 4fCCMUVwQXWJGsbpNnjA8W5q1RhocGWR27HW2PFY/C1CQyTj/GPVpBUBXv5+DwiVbjYM vQbWIROgMWgJRykfs+iREyCTc2XXVAqTSOe9yBpaRxJ0dbzI9avvUNc3rWPUPEb8eWWJ LJ06o+4b7SqqcLkFkd8nHo8L+vI+mM5EcF0kH8qYjPfMdUiyqhYf6L6o3ngUw+ZlywvD 4xlGUPZ0qV4WPjDHAHm8AGfRZrG3xWi5JcUKkqRD2STlFzuvdR9d185ZjHiy1hAga/c4 qL+w== X-Forwarded-Encrypted: i=1; AJvYcCU1/cF2X9GRDJB+e+Gr7KaYz8T5wZj1nU7ERc6EAu7hDzuYXvsSdrdYnmA5R5zkni5ekBOot7PtEuIMDLnk/vUZJ8m6BWX7Id3ww7+QMVe8C/zwel4= X-Gm-Message-State: AOJu0YzWfSDb8/qMVu1DnzqGqjc5vYW31XOgZFvRTsGPz0zeSmyAuzs9 3ZAwHNNGqFPk63c4i7fsn1S+k97DMXvF2n6dIYeO6k2CmOKujShGVqZuCSg1bic= X-Google-Smtp-Source: AGHT+IG3Lg7mm8hPe5LwKDEb0DtuBWPIrOCUnl2T2Z41lBT6Pyv73n0DcdIqqnsFwOJp3c6VQ0kGmA== X-Received: by 2002:a5d:64cf:0:b0:341:d7b5:27 with SMTP id f15-20020a5d64cf000000b00341d7b50027mr8950388wri.6.1712602134884; Mon, 08 Apr 2024 11:48:54 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:90bc:1f0d:aae2:3c66]) by smtp.gmail.com with ESMTPSA id m6-20020adff386000000b00343300a4eb8sm9561770wro.49.2024.04.08.11.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 11:48:54 -0700 (PDT) References: <20240408164947.30717-1-ddrokosov@salutedevices.com> <20240408164947.30717-2-ddrokosov@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Dmitry Rokosov Cc: neil.armstrong@linaro.org, lgirdwood@gmail.com, jbrunet@baylibre.com, broonie@kernel.org, conor+dt@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, martin.blumenstingl@googlemail.com, kernel@salutedevices.com, rockosov@gmail.com, linux-amlogic@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 1/2] ASoC: dt-bindings: meson: introduce link-name optional property Date: Mon, 08 Apr 2024 20:44:36 +0200 In-reply-to: <20240408164947.30717-2-ddrokosov@salutedevices.com> Message-ID: <1jsezvofl5.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_114857_569583_1FA32840 X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 08 Apr 2024 at 19:49, Dmitry Rokosov wrote: > The 'link-name' property is an optional DT property that allows for the > customization of the name associated with the DAI link and PCM stream. > This functionality mirrors the approach commonly utilized in Qualcomm > audio cards, providing flexibility in DAI naming conventions for > improved system integration and userspace experience. As explained in patch #2, I think this change is wrong. The names below describe a possible userspace usage of the interface, not HW. This does not belong in DT. The only valid name for the interface is one that helps map the PCM interface and the kcontrols exposed in userspace. This information is already available through dai_name, prefixes, etc. Using DT for this is bad, in the context of these particular sound cards at least. > > It allows userspace program to easy determine PCM stream purpose, e.g.: > ~ # cat /proc/asound/pcm > 00-00: speaker (*) : : playback 1 > 00-01: mics (*) : : capture 1 > 00-02: loopback (*) : : capture 1 > > Signed-off-by: Dmitry Rokosov > --- > .../devicetree/bindings/sound/amlogic,axg-sound-card.yaml | 6 ++++++ > .../devicetree/bindings/sound/amlogic,gx-sound-card.yaml | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > index 492b41cc8ccd..46774a3e4b1d 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > @@ -66,6 +66,11 @@ patternProperties: > maxItems: 1 > description: phandle of the CPU DAI > > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > patternProperties: > "^dai-tdm-slot-(t|r)x-mask-[0-3]$": > $ref: /schemas/types.yaml#/definitions/uint32-array > @@ -137,6 +142,7 @@ examples: > > dai-link-0 { > sound-dai = <&frddr_a>; > + link-name = "speaker"; > }; > > dai-link-1 { > diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml > index d4277d342e69..975c148f9712 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml > @@ -52,6 +52,11 @@ patternProperties: > maxItems: 1 > description: phandle of the CPU DAI > > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > patternProperties: > "^codec(-[0-9]+)?$": > type: object > @@ -89,6 +94,7 @@ examples: > > dai-link-0 { > sound-dai = <&i2s_fifo>; > + link-name = "speaker"; > }; > > dai-link-1 { -- Jerome _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel