From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E15D5C4332B for ; Sun, 22 Mar 2020 18:31:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B50CB206C3 for ; Sun, 22 Mar 2020 18:31:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e33+VAyv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="i9/EM43p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B50CB206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=g3VgCiuzY7y4v9bj45XAngjRrKH5Okbzdi0/9QWgmOw=; b=e33+VAyvxni3NL44b6OKyBmqvD T1GwibotdUbY3ixFI06jiLUW/tmjflzKdUodaYY38idX5jHVhIKdwSM/T6SH0qkAIwHHSI2RDAOoY Eer4WGot+Gvw9g2p8sgktSqGg6t21bcQKZJp3qP9Vt+c9raUSGlaPLS8O9V61hz7z3R4G3mFsrg+y iDxWDypFtaM9Aa8dLfrfKVsZry8b7xkNGLRiQM/GkDwtzUaHdBRF+bIeTYerHRgLGw7hlW8MDCk8L 36SazrXOKj7JK53XHpP0EI8bP8uxcgmzNA7Ra9nENKFRvVQjOqz9v2ka+82I1C66PwLNatMkVIqFq 2357usaw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jG5Nr-00036K-6b; Sun, 22 Mar 2020 18:31:39 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jG5Nn-00035H-8r for linux-arm-kernel@lists.infradead.org; Sun, 22 Mar 2020 18:31:37 +0000 Received: by mail-wr1-x443.google.com with SMTP id z15so14031314wrl.1 for ; Sun, 22 Mar 2020 11:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=t345tliBlqINDa8PSXt4lv98Z6uPV9ApDsTwoyUh4K8=; b=i9/EM43pwbkPODkA43IfFBziz7mD/e2iF6QmH9MXMkV9EccK1pkaR3rkTuF8/B8fI7 4Z+8vCAC/lxmreMsVBxcXHtkQ9nDEPc49qfT9K2JQY2ad7+kBpmT5zUEWR+uF0t//LPC 8AhdL3pPEdMamUDWdUXITgMN3Kpky5dMfJZvQTsEnkWoszljOc5ILpGVgBirodYJ9l+c uU9HINVEpKOEBNXi4PYSkyex0Yo70OrXvUFy4UhVMXU7WiWG/KgfsHEo9jhtREw26K3n oLY8u9EJG854eFvPSh/uvdoQKzyg9kgriDehTs5l9MhzrLrteW1u1wzrONNFlpBjPT6a /j8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=t345tliBlqINDa8PSXt4lv98Z6uPV9ApDsTwoyUh4K8=; b=IP1XP+gypzVeaDKitsg4Pft8rnHWtydbvbOwtcfnSmx5/1EPP0QV9KBGTVkF+z6o6x /V2XlqWasylFp55Ae7VAbJJBqVfdFv9aO31SyDdkOpVTPBLyVIF8YqRxhwWmeZe6BDev DWhmZO3cqvMe5V5Op6EFk3NmvRCHqZUqNDoAYrn7LCpR7aipP2yNx9lQQqgZo/bBHx8Q jn6cS4wcEsa+EOhPljbf+/lqLPO/iSm78RmuluVsZIuo+5ABExtoIsQGvBJXjx7gPNQq fhDfL9lCiKkdEFD+DUCdIrqWKJ9FhVuekV8e/2eXOeOxW65S57kTft0b5qsBmbEG86Te MGlw== X-Gm-Message-State: ANhLgQ2pHO0LqkTcw5LJlaCp1zZlw+3VojCGGuHGEC74voBjjKqeYBj1 cjGko7tBk+6hpagXTK5xvo9dFQvfx08= X-Google-Smtp-Source: ADFU+vtYl2tirhzygQLImaRvVxGsLaQ7qwRGlxRLIFaQgG6POo2NZlaxl4e7Zub8wnLdztr8JVbVyw== X-Received: by 2002:adf:b31d:: with SMTP id j29mr10790210wrd.218.1584901893310; Sun, 22 Mar 2020 11:31:33 -0700 (PDT) Received: from localhost (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.gmail.com with ESMTPSA id s1sm19915958wrp.41.2020.03.22.11.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2020 11:31:32 -0700 (PDT) References: <20200316023411.1263-1-sashal@kernel.org> <20200316023411.1263-8-sashal@kernel.org> <1ja74gg0v8.fsf@starbuckisacylon.baylibre.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.4 08/35] ASoC: meson: g12a: add tohdmitx reset In-reply-to: <1ja74gg0v8.fsf@starbuckisacylon.baylibre.com> Date: Sun, 22 Mar 2020 19:31:31 +0100 Message-ID: <1jsgi0ckcc.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200322_113135_377172_10CE667B X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, alsa-devel@alsa-project.org, Mark Brown , linux-arm-kernel@lists.infradead.org, Kevin Hilman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 16 Mar 2020 at 09:28, Jerome Brunet wrote: > On Mon 16 Mar 2020 at 03:33, Sasha Levin wrote: > >> From: Jerome Brunet >> >> [ Upstream commit 22946f37557e27697aabc8e4f62642bfe4a17fd8 ] >> >> Reset the g12a hdmi codec glue on probe. This ensure a sane startup state. >> >> Signed-off-by: Jerome Brunet >> Link: https://lore.kernel.org/r/20200221121146.1498427-1-jbrunet@baylibre.com >> Signed-off-by: Mark Brown >> Signed-off-by: Sasha Levin > > Hi Sasha, > > The tohdmitx reset property is not in the amlogic g12a DT in v5.4. > Backporting this patch on v5.4 would break the hdmi sound, and probably > the related sound card since the reset is not optional. > > Could you please drop this from v5.4 stable ? Hi Sasha, I just received a notification that this patch has been applied to 5.4 stable. As explained above, it will cause a regression. Could you please drop it from v5.4 stable ? Thanks Jerome > It is ok to keep it for v5.5. > > Thanks > Jerome > >> --- >> sound/soc/meson/g12a-tohdmitx.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/sound/soc/meson/g12a-tohdmitx.c b/sound/soc/meson/g12a-tohdmitx.c >> index 9cfbd343a00c8..8a0db28a6a406 100644 >> --- a/sound/soc/meson/g12a-tohdmitx.c >> +++ b/sound/soc/meson/g12a-tohdmitx.c >> @@ -8,6 +8,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -378,6 +379,11 @@ static int g12a_tohdmitx_probe(struct platform_device *pdev) >> struct device *dev = &pdev->dev; >> void __iomem *regs; >> struct regmap *map; >> + int ret; >> + >> + ret = device_reset(dev); >> + if (ret) >> + return ret; >> >> regs = devm_platform_ioremap_resource(pdev, 0); >> if (IS_ERR(regs)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel