From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60181D2127B for ; Fri, 18 Oct 2024 08:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HrncWdVx0bleY/RhYi61o0nRl8Zpr6NCNC/up3U4baE=; b=DRahoVFxRWLGd87xukm0kzeVrm YIdsmbK0Epn6laT2uGp6iJtgjFXERwfcbdP7dmkNzYbhXkdXD/zw9zA/N5yxcWIRFOke8ZI4lKvTJ cjgCJ3BHii+ujGqFe6h6SphY/aJ1l9lfOMSt7ZOramnYBKE+4agEo/zuZcPM1cfUjHn3Tm8oe19lP U8y+mLbSHSzyeHUSoSqXMRk8P31KUzejwMIAvGdiiboQYsgmknbbDNujTQTpXkJojlxX3aIy53pFE GWYg6VUS8xii4XVtua1JMlDc9G9YrYYFUIXY1li3DUolJE7jY9HSYveXcdcwDI5Kz7F/cmNIyIS3e lVAqkD8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1ifR-000000002k9-1u9n; Fri, 18 Oct 2024 08:49:05 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1iWB-0000000HafJ-2bTy for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 08:39:34 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43162cf1eaaso3561235e9.0 for ; Fri, 18 Oct 2024 01:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729240770; x=1729845570; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HrncWdVx0bleY/RhYi61o0nRl8Zpr6NCNC/up3U4baE=; b=3MNHUAKaIxSImv7vRwf8eAT5T392gd+BuUE1EuGW5H3wL9j5Ly9YQrAGFSKq6n7xqW qPtmvmdrZ8vShJE9w7N1d4UqvOnyRBFKjFZ3IPCD+6jzsdlntgw6n+t/ghpwuAGZc13Q +XdGfypjBUD3dY9eoVdHZvkdqg4YQNEcR1olMyWQhC8Ig7GJ1UG1JxBNojtNanxv2RJn gYvHc91pjrXNRHy3eearBNfTmtIZCgXnwO3Yi94D47kwMLNFbBuOnA/lVTGqwInUfGRJ pEPctn+zybU2l59P9mDMUHEBOyKkCJyxz2zXc+mMSgo2bkCp/tKlS/d7OrNOcVmu9TkA oBaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729240770; x=1729845570; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HrncWdVx0bleY/RhYi61o0nRl8Zpr6NCNC/up3U4baE=; b=FO4crEktbAfjmoD6kI/vTy/YNRnYyJ3p9WwF/Z6LU4uVtNZihY9uOdXou2Une4Xyx0 DKvMcEHTTKwRR6igoimmFfyw+XVco7o5R4P2T2UNmW1Ku3SfmFMSqvXzcNHGjm7kHbtT WBanfnzQeed/19VmY2hAgSBHHn98samEGvfFSvpq9ipZaLVNR23jaP85h+0qWJSu9FR2 mopqZAGAzVcBoRk1DkIf0gvBhReOh+AJT4xI+oMHteeEllL0u80p47PD4tjXZHWXskfN D8ZX41m5BSpPNhaiiVFT8pO/gxj9/YwaB3/YTucXx2QIuuwh++/kwiE2dbuuqq5I3T3a HaAQ== X-Forwarded-Encrypted: i=1; AJvYcCWvN2kPVyo2icvRY+FDyn7vp4GvNCEIA/7do5vR/K84xH5WBm75z1pXCD0uNlE148HvSmE7yI1fqy6IQxfGRQb4@lists.infradead.org X-Gm-Message-State: AOJu0Yx0vigcYGMpKBiXNeg7bezdTDMz7IkTi73XZ42PqLU5F/wAdMGN i9dMBVT2UwV2Kw9ZC04DRZ5O+CAB5l+0s2lTvHAGnz7GBgt5suS2Y08rzwb3gCY= X-Google-Smtp-Source: AGHT+IEtT0VrGwMXWD3f3PNN6+mMk8Niqje0hsKtwQA0iMPfyIkaGazeJqRT2ugGAgBVN1yXC2tZog== X-Received: by 2002:a05:600c:4e8b:b0:431:5c3d:1700 with SMTP id 5b1f17b1804b1-43161642386mr15793305e9.21.1729240769641; Fri, 18 Oct 2024 01:39:29 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:6e2b:4562:2d66:575e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43160e4fd55sm17360595e9.45.2024.10.18.01.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 01:39:29 -0700 (PDT) From: Jerome Brunet To: Krzysztof Kozlowski Cc: xianwei.zhao@amlogic.com, Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Amlogic A4 SoCs In-Reply-To: <4a79f996-9d82-48b2-8a93-d7917413ed8c@kernel.org> (Krzysztof Kozlowski's message of "Fri, 18 Oct 2024 10:28:51 +0200") References: <20241018-a4_pinctrl-v3-0-e76fd1cf01d7@amlogic.com> <20241018-a4_pinctrl-v3-1-e76fd1cf01d7@amlogic.com> <4a79f996-9d82-48b2-8a93-d7917413ed8c@kernel.org> Date: Fri, 18 Oct 2024 10:39:28 +0200 Message-ID: <1jttd9rein.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_013931_926246_A1CFBCAF X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 18 Oct 2024 at 10:28, Krzysztof Kozlowski wrote: > On 18/10/2024 10:10, Xianwei Zhao via B4 Relay wrote: >> From: Xianwei Zhao >> >> Add the new compatible name for Amlogic A4 pin controller, and add >> a new dt-binding header file which document the detail pin names. the change does not do what is described here. At least the description needs updating. So if the pin definition is now in the driver, does it mean that pins have to be referenced in DT directly using the made up numbers that are created in pinctrl-amlogic-a4.c at the beginning of patch #2 ? If that's case, it does not look very easy a read. >> >> Signed-off-by: Xianwei Zhao > > Acked-by: Krzysztof Kozlowski > > Best regards, > Krzysztof -- Jerome