From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
Date: Wed, 28 Jan 2015 14:53:07 +0100 [thread overview]
Message-ID: <2000255.rnmr9HfSOg@wuerfel> (raw)
The recent patch to convert the cns3xxx PCI code added an
extraneous opening bracket, which makes the build fail,
so remove this.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
---
Hi Bjorn,
The broken patch just showed up in linux-next. Please apply this one on top,
or fold it into the original patch if you don't mind rebasing.
diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
index e41fc339d100..c622c306c390 100644
--- a/arch/arm/mach-cns3xxx/pcie.c
+++ b/arch/arm/mach-cns3xxx/pcie.c
@@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
* for a PCIe bridge. So we must fixup the class code
* to 0x604 here.
*/
- *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
+ *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
return ret;
}
next reply other threads:[~2015-01-28 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 13:53 Arnd Bergmann [this message]
2015-01-28 15:17 ` [PATCH] ARM: cns3xxx: fix typo in PCI config accessor Bjorn Helgaas
2015-01-28 15:34 ` Rob Herring
2015-01-28 15:38 ` Bjorn Helgaas
2015-01-29 6:37 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2000255.rnmr9HfSOg@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).