linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Convert MMC subsys drivers to dev_pm_ops
Date: Sat, 22 Aug 2009 04:52:05 +0200	[thread overview]
Message-ID: <200908220452.05108.marek.vasut@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0908212234150.6044@xanadu.home>

Dne So 22. srpna 2009 04:44:00 Nicolas Pitre napsal(a):
> On Sat, 22 Aug 2009, Marek Vasut wrote:
> > Hi,
> >
> > This converts most of the drivers found in drivers/mmc/host to
> > dev_pm_ops. Also, it contains some fixes for the probe/remove functions
> > in some cases.
>
> Are you sure you're actually fixing things?
>
> You replaced platform_driver_probe() calls with
> platform_driver_register() calls, and made the probe functions __devinit
> instead of __init.  Especially when the platform device is unlikely to
> go away or new ones to ever appear, there is no point keeping the
> probe code around after it is done.

Yeah, the __devinit should actually remove the init function when done ... to 
my understanding. Sorry in case I'm wrong.
>
>
> Nicolas

  reply	other threads:[~2009-08-22  2:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-22  0:23 [PATCH] Convert MMC subsys drivers to dev_pm_ops Marek Vasut
2009-08-22  2:44 ` Nicolas Pitre
2009-08-22  2:52   ` Marek Vasut [this message]
2009-08-22  3:23     ` Nicolas Pitre
2009-08-22  5:13 ` Frans Pop
2009-08-22  8:16   ` Manuel Lauss
2009-08-22  8:27 ` Matt Fleming
2009-08-22  9:24   ` Marek Vasut
2009-08-22 21:56 ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908220452.05108.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).