From: elendil@planet.nl (Frans Pop)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Convert MMC subsys drivers to dev_pm_ops
Date: Sat, 22 Aug 2009 07:13:16 +0200 [thread overview]
Message-ID: <200908220713.20637.elendil@planet.nl> (raw)
In-Reply-To: <200908220223.50588.marek.vasut@gmail.com>
Marek Vasut wrote:
> +static struct dev_pm_ops cm710_mmc_pm_ops = {
> + .suspend = cb710_mmc_suspend,
> + .resume = cb710_mmc_resume,
> +};
This is almost certainly wrong (same for the other drivers you converted)
as they now no longer support hibernation, which requires different ops.
Please see: http://lkml.org/lkml/2009/7/25/118.
You also seem to have handled the #ifndef CONFIG_PM case incorrectly.
See http://lkml.org/lkml/2009/8/3/253 for an example how it can be done.
There have already been several threads on lkml discussing this. Please
search for posts with dev_pm_ops in the subject if you want more
information.
Also, please CC linux-pm at lists.linux-foundation.org on patches related to
this conversion.
Cheers,
FJP
next prev parent reply other threads:[~2009-08-22 5:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 0:23 [PATCH] Convert MMC subsys drivers to dev_pm_ops Marek Vasut
2009-08-22 2:44 ` Nicolas Pitre
2009-08-22 2:52 ` Marek Vasut
2009-08-22 3:23 ` Nicolas Pitre
2009-08-22 5:13 ` Frans Pop [this message]
2009-08-22 8:16 ` Manuel Lauss
2009-08-22 8:27 ` Matt Fleming
2009-08-22 9:24 ` Marek Vasut
2009-08-22 21:56 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908220713.20637.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).