linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] Treo680: remove unused LCD power GPIO
Date: Mon, 31 Aug 2009 19:34:51 +0200	[thread overview]
Message-ID: <200908311934.51750.marek.vasut@gmail.com> (raw)
In-Reply-To: <1251739561-28972-3-git-send-email-sleep_walker@suse.cz>

Dne Po 31. srpna 2009 19:25:58 Tom?? ?ech napsal(a):
> From: Tom?? ?ech <sleep walker@suse.cz>
>
>
> Signed-off-by: Tom?? ?ech <sleep_walker@suse.cz>
> ---
>  arch/arm/mach-pxa/treo680.c |   10 +---------
>  1 files changed, 1 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/treo680.c b/arch/arm/mach-pxa/treo680.c
> index 050ad8e..57bccc3 100644
> --- a/arch/arm/mach-pxa/treo680.c
> +++ b/arch/arm/mach-pxa/treo680.c
> @@ -254,16 +254,9 @@ static int treo680_backlight_init(struct device *dev)
>  	ret = gpio_direction_output(GPIO_NR_TREO680_BL_POWER, 0);
>  	if (ret)
>  		goto err2;
> -	ret = gpio_request(GPIO_NR_TREO680_LCD_POWER, "LCD POWER");
> -	if (ret)
> -		goto err2;
> -	ret = gpio_direction_output(GPIO_NR_TREO680_LCD_POWER, 0);
> -	if (ret)
> -		goto err3;
>
>  	return 0;
> -err3:
> -	gpio_free(GPIO_NR_TREO680_LCD_POWER);
> +
>  err2:
>  	gpio_free(GPIO_NR_TREO680_BL_POWER);
>  err:
> @@ -279,7 +272,6 @@ static int treo680_backlight_notify(int brightness)
>  static void treo680_backlight_exit(struct device *dev)
>  {
>  	gpio_free(GPIO_NR_TREO680_BL_POWER);
> -	gpio_free(GPIO_NR_TREO680_LCD_POWER);
>  }
>
>  static struct platform_pwm_backlight_data treo680_backlight_data = {

Why was that GPIO there before then? Does this have any effect on the boot 
problems you are experiencing with Centro/T680? Otherwise seems OK to me

Acked-by: Marek Vasut <marek.vasut@gmail.com>

  parent reply	other threads:[~2009-08-31 17:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31 17:25 update Treo680, generalise it and add Centro support - round 2 Tomáš Čech
2009-08-31 17:25 ` [PATCH 1/5] Treo680: pxamci simplify to use GPIO Tomáš Čech
2009-08-31 17:25   ` [PATCH 2/5] Treo680: remove unused LCD power GPIO Tomáš Čech
2009-08-31 17:25     ` [PATCH 3/5] Treo680: fix freed GPIO in treo680_irda_shutdown() Tomáš Čech
2009-08-31 17:26       ` [PATCH 4/5] PalmGSM: generalisation of Treo680 code to PalmGSM Tomáš Čech
2009-08-31 17:26         ` [PATCH 5/5] PalmGSM: add basic Centro support Tomáš Čech
2009-08-31 17:36       ` [PATCH 3/5] Treo680: fix freed GPIO in treo680_irda_shutdown() Marek Vasut
2009-09-01  9:52         ` Eric Miao
2009-08-31 17:34     ` Marek Vasut [this message]
2009-08-31 18:34       ` [PATCH 2/5] Treo680: remove unused LCD power GPIO Tomáš 'Sleep_Walker' Čech
2009-09-01  9:49         ` Eric Miao
2009-09-01 10:56           ` Tomáš 'Sleep_Walker' Čech
2009-09-01 11:42             ` Eric Miao
2009-09-01 16:14               ` Tomáš 'Sleep_Walker' Čech
     [not found]                 ` <f17812d70909012325h42a834cqad3627fb3e4fe62d@mail.gmail.com>
2009-09-02  6:28                   ` Eric Miao
2009-09-02  8:45                     ` Tomáš 'Sleep_Walker' Čech
2009-09-03 13:48                       ` Tomáš 'Sleep_Walker' Čech
2009-09-03 15:21                         ` Tomáš 'Sleep_Walker' Čech
2009-09-05  4:43                           ` Eric Miao
2009-09-06  8:27                             ` Tomáš 'Sleep_Walker' Čech
2009-08-31 17:33   ` [PATCH 1/5] Treo680: pxamci simplify to use GPIO Marek Vasut
2009-09-01  9:36     ` Eric Miao
  -- strict thread matches above, loose matches on Subject: below --
2009-08-27  0:43 update Treo680, generalise it and add Centro support Tomáš Čech
2009-08-27  0:43 ` [PATCH 1/5] Treo680: pxamci simplify to use GPIO Tomáš Čech
2009-08-27  0:43   ` [PATCH 2/5] Treo680: remove unused LCD power GPIO Tomáš Čech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908311934.51750.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).