[PATCH 4/5] PalmGSM: generalisation of Treo680 code to PalmGSM

[sleep_walker@suse.cz (Tomáš 'Sleep_Walker' Čech)]

Ahoj! :)

Dne ?t 1. z??? 2009 02:07:16 Pavel Machek napsal(a):
> Ahoj! / Hi!
> 
> > > > > > arch/arm/mach-pxa/Kconfig                |    5 +
> > > > > > arch/arm/mach-pxa/Makefile               |    2 +-
> > > > > > arch/arm/mach-pxa/include/mach/palmgsm.h |   60 ++++
> > > > > > arch/arm/mach-pxa/include/mach/treo680.h |   49 ---
> > > > > > arch/arm/mach-pxa/palmgsm.c              |  559 ++++++++++++++++++++++++++++++
> > > > > > arch/arm/mach-pxa/treo680.c              |  528 ----------------------------
> > > > > 
> > > > > I don't actually care too much about the naming - as long as 685 can stay 
> > > > > within treo680.c, I don't see any problem with that. The real question is:
> > > > > is palmgsm.c the proper name for all these devices?
> > > > 
> > > > Well, actually your completely right. PalmGSM is not fitting for all devices to come, more fitting would be something like Palm smartphones because there are CDMA devices to come too. On the other hand, this name is the best I found so far. If you don't mind I would even so...
> > > >
> > > 
> > > I believe treo680 was better name then. Don't change it if you don't
> > > need to...
> > 
> > But I need to have different generic name - treo680 will be occupied by Treo680 specific stuff, which makes more sense, doesn't it?
> > 
> 
> And rename generic code to treo.c? Then you could have treo.c for
> generic code, and treo680.c / treo685.c for specific models...
> 
> palmgsm.c sounds like driver for their GSM chip...
> 									Pavel
> 
OK, treo.c would be best (even though that one model has name Centro), I'll recreate patch set. I'm just a bit afraid of treo650_, treo680, treo700p_, treo755p_ and treo_ naming (the code will be a bit more worse to read), but right - this is the best name.

Thanks!

Tomas Cech