From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: copy_page.S: take into account the size of the cache line
Date: Wed, 2 Sep 2009 14:24:23 +0100 [thread overview]
Message-ID: <20090902132423.GA12595@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1251907913-16261-2-git-send-email-kirill@shutemov.name>
On Wed, Sep 02, 2009 at 07:11:53PM +0300, Kirill A. Shutemov wrote:
> ENTRY(copy_page)
> stmfd sp!, {r4, lr} @ 2
> PLD( pld [r1, #0] )
> - PLD( pld [r1, #32] )
> + PLD( pld [r1, #L1_CACHE_BYTES] )
> mov r2, #COPY_COUNT @ 1
> ldmia r1!, {r3, r4, ip, lr} @ 4+1
> -1: PLD( pld [r1, #64] )
> - PLD( pld [r1, #96] )
> -2: stmia r0!, {r3, r4, ip, lr} @ 4
> - ldmia r1!, {r3, r4, ip, lr} @ 4+1
> - stmia r0!, {r3, r4, ip, lr} @ 4
> - ldmia r1!, {r3, r4, ip, lr} @ 4+1
> +1: PLD( pld [r1, #(2*L1_CACHE_BYTES)])
> + PLD( pld [r1, #(3*L1_CACHE_BYTES)])
I really hate unnecessary parens - please remove them, and put a space
each side of the '*'.
> +2:
> + .rept (2 * (L1_CACHE_BYTES) / 16 - 1)
Parens are not required around L1_CACHE_BYTES either.
Other than that, patch is fine.
next prev parent reply other threads:[~2009-09-02 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 16:11 [PATCH 1/2] ARM: Introduce ARM_L1_CACHE_SHIFT to define cache line size Kirill A. Shutemov
2009-09-02 16:11 ` [PATCH 2/2] ARM: copy_page.S: take into account the size of the cache line Kirill A. Shutemov
2009-09-02 13:24 ` Russell King - ARM Linux [this message]
2009-09-02 17:19 ` [PATCH] " Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902132423.GA12595@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).