From: mad_soft@inbox.ru (Dmitry Artamonow)
To: linux-arm-kernel@lists.infradead.org
Subject: Collie/Simpad hacks in head-sa1100.S break booting on other machines
Date: Wed, 9 Sep 2009 16:54:20 +0400 [thread overview]
Message-ID: <20090909125420.GA13915@rainbow> (raw)
Hello!
When trying to boot kernel with both CONFIG_SA1100_COLLIE and
CONFIG_SA1100_H3600 compiled in on iPaq h3600, I suddenly have been
bitten by this hack in arch/arm/boot/compressed/head-sa1100.S:
#ifdef CONFIG_SA1100_COLLIE
mov r7, #MACH_TYPE_COLLIE
#endif
Yes, it's silently sets machine ID to MACH_TYPE_COLLIE on _any_ SA1100 machine
if CONFIG_SA1100_COLLIE is set. And there's also similar hack (or broken
bootloader workaround, if you like) for Simpad.
I don't know if these hacks are needed anymore (for Collie with stock
bootloader probably yes, for Simpad I don't know as I don't have this
hardware), but I think something should be done at least to prevent
selecting other machines if CONFIG_SA1100_COLLIE or CONFIG_SA1100_SIMPAD
selected. Please find not very elegant, but working patch in attahment.
It just adds "depends on !SA1100_COLLIE && !SA1100_SIMPAD" to every other
machine. Sadly, I'm not an expert in kconfig - maybe there's a better way
to do that?
--
Best regards,
Dmitry "MAD" Artamonow
next reply other threads:[~2009-09-09 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 12:54 Dmitry Artamonow [this message]
2009-09-10 2:14 ` Collie/Simpad hacks in head-sa1100.S break booting on other machines Eric Miao
2009-09-15 11:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909125420.GA13915@rainbow \
--to=mad_soft@inbox.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox