From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: calls to notify_die missing -> ftrace_dump_on_oops non-functional
Date: Sat, 12 Sep 2009 21:54:54 +0200 [thread overview]
Message-ID: <20090912195454.GA32429@pengutronix.de> (raw)
Hello,
I noticed yesterday that ARM doesn't call notify_die (added in
1eeb66a (move die notifier handling to common code)
).
As ftrace_dump_on_oops depends on this function being called I don't get
an ftrace dump in my oopses.
Locally I added
notify_die(DIE_OOPS, str, regs, err, current->thread.trap_no, SIGSEGV);
at the end of __die() in arch/arm/kernel/traps.c but I think this is not
completely correct because---assuming I understood it
correctly---notify_die returning NOTIFY_STOP should stop the process
dying. Christoph, is this correct?
Dying on ARM looks quite different to dying on x86. Russell, what's
your position here? Would you accept a patch that makes them more
similar?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next reply other threads:[~2009-09-12 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 19:54 Uwe Kleine-König [this message]
2009-09-12 21:36 ` calls to notify_die missing -> ftrace_dump_on_oops non-functional Russell King - ARM Linux
2009-09-13 19:55 ` Uwe Kleine-König
2009-09-13 20:01 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912195454.GA32429@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).