linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: remove unused code in delay.S
Date: Mon, 14 Sep 2009 18:24:57 +0200	[thread overview]
Message-ID: <20090914162457.GE3164@pengutronix.de> (raw)
In-Reply-To: <94a0d4530909140906v72865664w3976766e57bf2aa3@mail.gmail.com>


> The minority that would make use of this code is theoretical, and
> these users by definition know they need this code, therefore, if the
> code is not there, they'll notice,

I'm not sure everyone knows in advance what is going on. I imagine the case
where something is inadeqaute, one starts looking at the code and _after_
reading the #if 0-block, understands the problem and realizes that the block is
needed in this rare case. So, it's like some kind of documentation. This is why
I'd still favour the comment; if there is a chance for such a patch, I'd make
it BTW.

> If it turns out nobody complains about removing this code you would
> have made the linux kernel 16 lines cleaner for free.

I'd think we lose a bit of information. (Yeah, it is in the history, but harder
to find there.)

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090914/b48967cf/attachment.sig>

  reply	other threads:[~2009-09-14 16:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-13 21:05 [PATCH] arm: remove unused code in delay.S Felipe Contreras
2009-09-13 21:28 ` Marek Vasut
2009-09-13 23:00   ` Russell King - ARM Linux
2009-09-14  0:21     ` Jamie Lokier
2009-09-14  8:10       ` Russell King - ARM Linux
2009-09-14 12:58         ` Felipe Contreras
2009-09-14 14:00           ` Russell King - ARM Linux
2009-09-14 14:38             ` Felipe Contreras
2009-09-14 14:40               ` Russell King - ARM Linux
2009-09-14 15:14                 ` Felipe Contreras
2009-09-14 15:21                   ` Russell King - ARM Linux
2009-09-14 15:50                     ` Felipe Contreras
2009-09-14 16:25                       ` Marek Vasut
2009-09-14 16:54                         ` Felipe Contreras
2009-09-14 15:36                   ` Wolfram Sang
2009-09-14 16:06                     ` Felipe Contreras
2009-09-14 16:24                       ` Wolfram Sang [this message]
2009-09-15 10:37                   ` Pavel Machek
2009-09-15 10:47                     ` Felipe Contreras
2009-09-15 10:49                       ` Pavel Machek
2009-09-15 11:20                         ` Felipe Contreras
2009-09-15 12:29                     ` Steve Chen
2009-09-15 13:41                       ` Marek Vasut
2009-09-15 16:30                         ` Steve Chen
2009-09-15 18:58                           ` Felipe Contreras
2009-09-15 19:44                             ` Steve Chen
2009-09-15 20:39                               ` Marek Vasut
2009-09-15 21:04                               ` Krzysztof Halasa
2009-09-15 22:26                                 ` Steve Chen
2009-09-15 22:47                                   ` Krzysztof Halasa
2009-09-16  8:26                                     ` Steve Chen
2009-09-16 12:30                                       ` Krzysztof Halasa
2009-09-16 14:49                                         ` Steve Chen
2009-09-16 20:21                                           ` Sergei Shtylyov
2009-09-16 13:47                                 ` Russell King - ARM Linux
2009-09-17 19:32                                   ` Jamie Lokier
2009-09-17 19:41                                     ` Russell King - ARM Linux
2009-09-17 21:29                                       ` [PATCH v2] " Steve Chen
2009-09-17 21:37                                         ` Jamie Lokier
2009-09-17 22:25                                           ` Steve Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090914162457.GE3164@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).