linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/10] S3C I2S: lrsync function made to work with IRQs disabled.
Date: Tue, 15 Sep 2009 13:21:14 +0100	[thread overview]
Message-ID: <20090915122114.GP22878@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1253008957-10569-1-git-send-email-jassi.brar@samsung.com>

On Tue, Sep 15, 2009 at 07:02:37PM +0900, Jassi wrote:
> s3c2412_snd_lrsync() maybe reached with IRQs disabled and if LRCLK
> is dead due to improper initialization of CPU or CODEC, the system
> gets stuck in the loop because jiffies may never get updated.
> Implemented counter based wait mechanism for atleast the same
> timeout period.

I'll apply this but...

> +#define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t)

...this really should be moved into a standard header since it's a bit
of a namespace violation.  Also, there's a jiffies_to_msecs function.

  reply	other threads:[~2009-09-15 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 10:02 [PATCH 05/10] S3C I2S: lrsync function made to work with IRQs disabled Jassi
2009-09-15 12:21 ` Mark Brown [this message]
2009-09-16  0:14 ` Ben Dooks
2009-09-16  1:03   ` jassi brar
2009-09-16 10:26     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090915122114.GP22878@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).