* [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined
@ 2009-09-15 10:02 Jassi
2009-09-15 10:17 ` Mark Brown
2009-09-16 0:09 ` Ben Dooks
0 siblings, 2 replies; 5+ messages in thread
From: Jassi @ 2009-09-15 10:02 UTC (permalink / raw)
To: linux-arm-kernel
Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as
it's not avaialble for 6400
Signed-Off-by: Jassi <jassi.brar@samsung.com>
---
arch/arm/mach-s3c6400/include/mach/map.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
index 5057d99..775577a 100644
--- a/arch/arm/mach-s3c6400/include/mach/map.h
+++ b/arch/arm/mach-s3c6400/include/mach/map.h
@@ -44,6 +44,9 @@
#define S3C64XX_PA_SYSCON (0x7E00F000)
#define S3C64XX_PA_IIS0 (0x7F002000)
#define S3C64XX_PA_IIS1 (0x7F003000)
+#ifdef CONFIG_CPU_S3C6410
+#define S3C64XX_PA_IISV4 (0x7F00D000)
+#endif
#define S3C64XX_PA_TIMER (0x7F006000)
#define S3C64XX_PA_IIC0 (0x7F004000)
#define S3C64XX_PA_IIC1 (0x7F00F000)
--
1.6.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined
2009-09-15 10:02 [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined Jassi
@ 2009-09-15 10:17 ` Mark Brown
2009-09-16 0:09 ` Ben Dooks
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2009-09-15 10:17 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 15, 2009 at 07:02:33PM +0900, Jassi wrote:
> Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as
> it's not avaialble for 6400
> Signed-Off-by: Jassi <jassi.brar@samsung.com>
> #define S3C64XX_PA_IIS1 (0x7F003000)
> +#ifdef CONFIG_CPU_S3C6410
> +#define S3C64XX_PA_IISV4 (0x7F00D000)
> +#endif
I'm not sure what the roadmap for future CPUs looks like but might this
better done with the inverse test so we don't have to add every single
new CPU to the ifdefs. TBH I'm not sure if the ifdefs are worth it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined
2009-09-15 10:02 [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined Jassi
2009-09-15 10:17 ` Mark Brown
@ 2009-09-16 0:09 ` Ben Dooks
2009-09-16 0:50 ` jassi brar
1 sibling, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2009-09-16 0:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 15, 2009 at 07:02:33PM +0900, Jassi wrote:
> Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as
> it's not avaialble for 6400
>
> Signed-Off-by: Jassi <jassi.brar@samsung.com>
> ---
> arch/arm/mach-s3c6400/include/mach/map.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
> index 5057d99..775577a 100644
> --- a/arch/arm/mach-s3c6400/include/mach/map.h
> +++ b/arch/arm/mach-s3c6400/include/mach/map.h
> @@ -44,6 +44,9 @@
> #define S3C64XX_PA_SYSCON (0x7E00F000)
> #define S3C64XX_PA_IIS0 (0x7F002000)
> #define S3C64XX_PA_IIS1 (0x7F003000)
> +#ifdef CONFIG_CPU_S3C6410
> +#define S3C64XX_PA_IISV4 (0x7F00D000)
> +#endif
Does this really need to be #ifdef'd out? You might want to avoid
building the device setup code, or similar if it is only for a s3c6400
but this should be done by the machine Kconfig chosing to build the
support in for the machines that do need it.
I see no good reason for this to be applied.
> #define S3C64XX_PA_TIMER (0x7F006000)
> #define S3C64XX_PA_IIC0 (0x7F004000)
> #define S3C64XX_PA_IIC1 (0x7F00F000)
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined
2009-09-16 0:09 ` Ben Dooks
@ 2009-09-16 0:50 ` jassi brar
2009-09-16 1:07 ` Ben Dooks
0 siblings, 1 reply; 5+ messages in thread
From: jassi brar @ 2009-09-16 0:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 16, 2009 at 9:09 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Tue, Sep 15, 2009 at 07:02:33PM +0900, Jassi wrote:
>> Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as
>> it's not avaialble for 6400
>>
>> Signed-Off-by: Jassi <jassi.brar@samsung.com>
>> ---
>> ?arch/arm/mach-s3c6400/include/mach/map.h | ? ?3 +++
>> ?1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
>> index 5057d99..775577a 100644
>> --- a/arch/arm/mach-s3c6400/include/mach/map.h
>> +++ b/arch/arm/mach-s3c6400/include/mach/map.h
>> @@ -44,6 +44,9 @@
>> ?#define S3C64XX_PA_SYSCON ? ?(0x7E00F000)
>> ?#define S3C64XX_PA_IIS0 ? ? ? ? ? ? ?(0x7F002000)
>> ?#define S3C64XX_PA_IIS1 ? ? ? ? ? ? ?(0x7F003000)
>> +#ifdef CONFIG_CPU_S3C6410
>> +#define S3C64XX_PA_IISV4 ? ? (0x7F00D000)
>> +#endif
>
> Does this really need to be #ifdef'd out? You might want to avoid
> building the device setup code, or similar if it is only for a s3c6400
> but this should be done by the machine Kconfig chosing to build the
> support in for the machines that do need it.
>
> I see no good reason for this to be applied.
In my second post in this thread, i already said the ifdef had better
be dropped.
So, you want me to resend patch without the ifdef?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined
2009-09-16 0:50 ` jassi brar
@ 2009-09-16 1:07 ` Ben Dooks
0 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2009-09-16 1:07 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 16, 2009 at 09:50:59AM +0900, jassi brar wrote:
> On Wed, Sep 16, 2009 at 9:09 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Tue, Sep 15, 2009 at 07:02:33PM +0900, Jassi wrote:
> >> Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as
> >> it's not avaialble for 6400
> >>
> >> Signed-Off-by: Jassi <jassi.brar@samsung.com>
> >> ---
> >> ?arch/arm/mach-s3c6400/include/mach/map.h | ? ?3 +++
> >> ?1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
> >> index 5057d99..775577a 100644
> >> --- a/arch/arm/mach-s3c6400/include/mach/map.h
> >> +++ b/arch/arm/mach-s3c6400/include/mach/map.h
> >> @@ -44,6 +44,9 @@
> >> ?#define S3C64XX_PA_SYSCON ? ?(0x7E00F000)
> >> ?#define S3C64XX_PA_IIS0 ? ? ? ? ? ? ?(0x7F002000)
> >> ?#define S3C64XX_PA_IIS1 ? ? ? ? ? ? ?(0x7F003000)
> >> +#ifdef CONFIG_CPU_S3C6410
> >> +#define S3C64XX_PA_IISV4 ? ? (0x7F00D000)
> >> +#endif
> >
> > Does this really need to be #ifdef'd out? You might want to avoid
> > building the device setup code, or similar if it is only for a s3c6400
> > but this should be done by the machine Kconfig chosing to build the
> > support in for the machines that do need it.
> >
> > I see no good reason for this to be applied.
> In my second post in this thread, i already said the ifdef had better
> be dropped.
> So, you want me to resend patch without the ifdef?
Yes. remove #ifdef.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-16 1:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-15 10:02 [PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined Jassi
2009-09-15 10:17 ` Mark Brown
2009-09-16 0:09 ` Ben Dooks
2009-09-16 0:50 ` jassi brar
2009-09-16 1:07 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).