From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.
Date: Wed, 16 Sep 2009 01:47:38 +0100 [thread overview]
Message-ID: <20090916004737.GR13508@trinity.fluff.org> (raw)
In-Reply-To: <1252392769-31159-1-git-send-email-thomas.ab@samsung.com>
On Tue, Sep 08, 2009 at 03:52:49PM +0900, thomas.ab at samsung.com wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
>
> This patch enables ADMA feature in 6410 SDHCI controller
> driver.
Hmm, surely this wouldn't have wrapped and could have goine onto one line?
Also no signoff.
> ---
> drivers/mmc/host/sdhci-s3c.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index db1bb93..7f5b64e 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -329,12 +329,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> host->irq = irq;
>
> /* Setup quirks for the controller */
> -
> - /* Currently with ADMA enabled we are getting some length
> - * interrupts that are not being dealt with, do disable
> - * ADMA until this is sorted out. */
> - host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
> - host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
> + host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
>
> #ifndef CONFIG_MMC_SDHCI_S3C_DMA
>
> --
> 1.5.3.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
prev parent reply other threads:[~2009-09-16 0:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 6:52 [PATCH 4/8] s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller thomas.ab at samsung.com
2009-09-16 0:47 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916004737.GR13508@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).