From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] S3C64XX I2S: Return correct codec clock
Date: Wed, 16 Sep 2009 12:09:37 +0100 [thread overview]
Message-ID: <20090916110937.GE3589@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1b68c6790909152216od3f372ftc2fa3db488e6996@mail.gmail.com>
On Wed, Sep 16, 2009 at 02:16:54PM +0900, jassi brar wrote:
> Wait, there is no option for selecting I2SCLK in the manual. That is
> behind the MUX along with Mpll/Epll Out etc.
> In the driver we actually have all the correct options : PCLK or
> CLKAUDIO(which is the output of the MUX).
> The IMS bit can select only either PCLK or CLKAUDIO.So, i guess
The datasheet I have says an IMS setting of 11 selects I2SCLK and an IMS
setting of 01 selects CLKAUDIOx. This seems odd to say the least but is
consistent with the move to a 2 bit register field for IMS rather than
adding a second register field for selection of master mode clock.
Could just be poor documentation, but it could be a restriction on the
clock that can be used in slave mode or an error in the diagram.
> the patch is fine as it is.
It at least needs checkpatch issues fixing.
next prev parent reply other threads:[~2009-09-16 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 10:02 [PATCH 08/10] S3C64XX I2S: Return correct codec clock Jassi
2009-09-15 11:06 ` Mark Brown
2009-09-15 11:21 ` jassi brar
2009-09-15 11:56 ` Mark Brown
2009-09-16 5:16 ` jassi brar
2009-09-16 11:09 ` Mark Brown [this message]
2009-09-16 11:50 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916110937.GE3589@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).