[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[Vasily Khoruzhick]

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3c2410_udc-2440_dual_packet-workaround.patch
Type: text/x-patch
Size: 2470 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090923/2771ea8c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090923/2771ea8c/attachment.sig>

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[David Anders]

Vasily,

i have tried this patch on a number of S3C2440 based systems and found that this patch is not a completely effective solution. if the purpose is to get a solution even if it is an incomplete one, then i'd be ok with this patch, however, i'm not keen on accepting a patch into the main tree with the knowledge that it isn't 100% effective.

Dave Anders


--- On Wed, 9/23/09, Vasily Khoruzhick <anarsoul@gmail.com> wrote:

> From: Vasily Khoruzhick <anarsoul@gmail.com>
> Subject: [PATCH 1/5] s3c2410_udc: 2440 dual packet workaround
> To: "Ben Dooks" <ben-linux@fluff.org>, linux-arm-kernel at lists.infradead.org
> Date: Wednesday, September 23, 2009, 2:46 AM
> 
> 
> -----Inline Attachment Follows-----
> 
> 
> -----Inline Attachment Follows-----
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


      

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[Robert Jarzmik]

Vasily Khoruzhick <anarsoul@gmail.com> writes:

> This needs to be examined further. For now, the patch seems to do the
> trick.
>
> Note that this is not a clean solution by any means, because we
> might potentially get stuck in that interrupt for quite a while.

Hi Vasily,

That workaround could also freeze the kernel if hardware fails, can't it ?

If there is no better patch found, Wouldn't this patch benefit at least a
counter to get out of the interrupt handler if the hardware doesn't behave at
the Nth loop ?

Cheers.

--
Robert

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[Vasily Khoruzhick]

? ????????? ?? 23 ???????? 2009 22:20:05 ????? David Anders ???????:
> Vasily,
> 
> i have tried this patch on a number of S3C2440 based systems and found that
>  this patch is not a completely effective solution. if the purpose is to
>  get a solution even if it is an incomplete one, then i'd be ok with this
>  patch, however, i'm not keen on accepting a patch into the main tree with
>  the knowledge that it isn't 100% effective.

Hi, Dave

s3c2410_udc driver is almost useless (at least it's very inconvenient) on 
s3c244x machines without this patch. I think it's much better to have 
incomplete solution than broken driver.

Btw, I can resend patchset without this patch if maintainer of this driver 
thinks that accepting this patch is bad idea.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090923/1db519e5/attachment.sig>

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[Vasily Khoruzhick]

? ????????? ?? 23 ???????? 2009 22:24:34 ????? Robert Jarzmik ???????:
> If there is no better patch found, Wouldn't this patch benefit at least a
> counter to get out of the interrupt handler if the hardware doesn't behave
>  at the Nth loop ?

Of course, it won't be hard to implement. I'll wait for comments on other 4 
patches, fix them and then resend whole patchset.

Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090923/f4c9ed12/attachment.sig>

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[Ben Dooks]

On Wed, Sep 23, 2009 at 12:20:05PM -0700, David Anders wrote:
> Vasily,
> 
> i have tried this patch on a number of S3C2440 based systems and found that this patch is not a completely effective solution. if the purpose is to get a solution even if it is an incomplete one, then i'd be ok with this patch, however, i'm not keen on accepting a patch into the main tree with the knowledge that it isn't 100% effective.
> 
> Dave Anders

I think that if this is afix that makes the code mostly work then
there really should be some form of note in the code that says that this
fix is a mostly effective form.
 
> 
> --- On Wed, 9/23/09, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> 
> > From: Vasily Khoruzhick <anarsoul@gmail.com>
> > Subject: [PATCH 1/5] s3c2410_udc: 2440 dual packet workaround
> > To: "Ben Dooks" <ben-linux@fluff.org>, linux-arm-kernel at lists.infradead.org
> > Date: Wednesday, September 23, 2009, 2:46 AM
> > 
> > 
> > -----Inline Attachment Follows-----
> > 
> > 
> > -----Inline Attachment Follows-----
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > 
> 
> 
>       

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[Vasily Khoruzhick]

? ????????? ?? 24 ???????? 2009 08:11:17 ????? Fabian Godehardt ???????:
> On our 2440 machine i found out that adding a receive handling on the
> interrupt handler makes the driver work, and in ethernet gadget mode the
>  pings returned much faster.
> Im not realy familiar with the USB layer / protocoll so i'm not sure if
>  this breaks something else. You might have a look at this patch (it is
>  2.6.26 against 2.6.31 so maybe it will not apply successfully and you need
>  to take a hand on it).

Your patch works as well with little modification (you used && instead of &). 
And it seems to be a bit cleaner, it can't stuck in interrupt handler for a 
while as previous. Would you mind if I submit your patch as part of my 
patches? I'll add note that you're author of original patch.

Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090924/7518df98/attachment.sig>

[PATCH 1/5] s3c2410_udc: 2440 dual packet workaround

[Fabian Godehardt]

Hi Vasily,

Am Donnerstag 24 September 2009 21:38:06 schrieb Vasily Khoruzhick:
> Your patch works as well with little modification (you used && instead of
>  &). And it seems to be a bit cleaner, it can't stuck in interrupt handler
>  for a while as previous. Would you mind if I submit your patch as part of
>  my patches? I'll add note that you're author of original patch.

I have no problem with it. Please submit it with your patches. Thanks.


Regards,
Fabian Godehardt

-- 
Dipl.-Ing. (FH) Fabian Godehardt, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 G?ttingen, Germany
Sitz der Gesellschaft: G?ttingen, Amtsgericht G?ttingen HR B 3160
Gesch?ftsf?hrer: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner