platform data for the s3c-adc or hardcoded delay?

platform data for the s3c-adc or hardcoded delay?

[Nelson Castillo]

(Ben, sorry for sending 2 copies. I used the old list address... I'd
better go to sleep now.).


We had this for the touchscreen but it doesn't make sense now that the
driver has been converted to use the s3c-adc API.

const static struct s3c_ts_platdata gta02_ts_cfg = {
? ? ? .delay = 10000,
? ? ? .presc = 0xff, /* Slow as we can go. */
};

Without this delay the TS doesn't work for us:

Now I see two options:

1) Hardcode the delay in plat-s3c24xx/adc.c (As it's done in [1]).
2) Submit patches adding s3c_adc_platdata.

What do I do?

I also would like to know if we rule out the possibility of
delay/presc depending on the current s3c_adc_client.

[1] http://lists.openmoko.org/pipermail/openmoko-kernel/2009-September/010550.html

platform data for the s3c-adc or hardcoded delay?

[Arnaud Patard (Rtp)]

Nelson Castillo <arhuaco@freaks-unidos.net> writes:

Hi,

> (Ben, sorry for sending 2 copies. I used the old list address... I'd
> better go to sleep now.).
>
>
> We had this for the touchscreen but it doesn't make sense now that the
> driver has been converted to use the s3c-adc API.
>
> const static struct s3c_ts_platdata gta02_ts_cfg = {
> ? ? ? .delay = 10000,
> ? ? ? .presc = 0xff, /* Slow as we can go. */
> };
>
> Without this delay the TS doesn't work for us:
>
> Now I see two options:
>
> 1) Hardcode the delay in plat-s3c24xx/adc.c (As it's done in [1]).
> 2) Submit patches adding s3c_adc_platdata.

I would rather go for a platdata. I do believe that prescaler and delay
are machine specifics.

Arnaud

platform data for the s3c-adc or hardcoded delay?

[Ben Dooks]

On Wed, Sep 23, 2009 at 05:36:33AM -0500, Nelson Castillo wrote:
> (Ben, sorry for sending 2 copies. I used the old list address... I'd
> better go to sleep now.).
> 
> 
> We had this for the touchscreen but it doesn't make sense now that the
> driver has been converted to use the s3c-adc API.
> 
> const static struct s3c_ts_platdata gta02_ts_cfg = {
> ? ? ? .delay = 10000,
> ? ? ? .presc = 0xff, /* Slow as we can go. */
> };
> 
> Without this delay the TS doesn't work for us:
> 
> Now I see two options:
> 
> 1) Hardcode the delay in plat-s3c24xx/adc.c (As it's done in [1]).
> 2) Submit patches adding s3c_adc_platdata.

The pre-scaler value is probably something we should be passing to the
ADC core driver via platform data, I think that the rate that the conversions
are run at is a property of the board itself and not just the client. This
is mostly due to (I think) the ADC drawing more power the faster it runs
and the board may have only been designed to supply a certain amount of
power to the ADC.

The delay value is probably something that the client structure should
contain and the ADC driver set the delay value when the client is first
selected to start a conversion. 
 
> What do I do?
> 
> I also would like to know if we rule out the possibility of
> delay/presc depending on the current s3c_adc_client.
> 
> [1] http://lists.openmoko.org/pipermail/openmoko-kernel/2009-September/010550.html
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.