linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-iop32x/ Add nec ns-50 / ApplianceWare sanmina support
Date: Thu, 24 Sep 2009 22:59:15 +0100	[thread overview]
Message-ID: <20090924215915.GA27322@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <87hbut7890.fsf@lechat.rtp-net.org>

On Wed, Sep 23, 2009 at 09:48:11PM +0200, Arnaud Patard wrote:
> +static struct plat_serial8250_port sanmina_serial_port[] = {
> +	{
> +		.mapbase	= IQ31244_UART,
> +		.membase	= (char *)IQ31244_UART,

This can't be right.

> +		.irq		= IRQ_IOP32X_XINT3,
> +		.flags		= UPF_SKIP_TEST | UPF_SHARE_IRQ,
> +		.iotype		= UPIO_MEM,
> +		.regshift	= 0,
> +		.uartclk	= 14745600,
> +	},
> +	{ },
> +};
> +
> +static struct resource sanmina_uart_resource = {
> +	.start		= IQ31244_UART,
> +	.end		= IQ31244_UART + 0x3f,

and neither can this.  Resources are bus addresses, not virtual addresses.

  reply	other threads:[~2009-09-24 21:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ocr6uyhx.fsf@lechat.rtp-net.org>
2009-08-30 23:46 ` [PATCH] mach-iop32x/ Add nec ns-50 / ApplianceWare sanmina support Dan Williams
2009-09-23 19:48   ` Arnaud Patard (Rtp)
2009-09-24 21:59     ` Russell King - ARM Linux [this message]
2009-09-25  8:27       ` Arnaud Patard (Rtp)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090924215915.GA27322@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).