linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] Add suspend/resume support for rx1950
Date: Sun, 27 Sep 2009 10:01:08 +0300	[thread overview]
Message-ID: <200909271001.20642.anarsoul@gmail.com> (raw)
In-Reply-To: <20090927061951.GM31920@trinity.fluff.org>

? ????????? ?? 27 ???????? 2009 09:19:51 ????? Ben Dooks ???????:
> >  		__raw_writel(calc, phys_to_virt(H1940_SUSPEND_CHECKSUM));
> > +		if (machine_is_rx1950()) {
> > +			/* According to S3C2442 user's manual, page 7-17,
> > +			 * when the system is operating in NAND boot mode,
> > +			 * the hardware pin configuration - EINT[23:21] ???
> > +			 * must be set as input for starting up after
> > +			 * wakeup from sleep mode */
> 
> given this is generic to the s3c2442, why put this here? it also holds
> for the s3c2440 too... think about an implementation for the cpu's
> sysdev for all nand-booting systems.

Well, actually I thought that suspend for h1940 and rx3000 works without these 
tricks... Ok, I'll make it generic for s3c2442 CPU.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090927/1a0fe903/attachment.sig>

  reply	other threads:[~2009-09-27  7:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-26 21:04 [PATCH v2 4/5] Add suspend/resume support for rx1950 Vasily Khoruzhick
2009-09-27  6:19 ` Ben Dooks
2009-09-27  7:01   ` Vasily Khoruzhick [this message]
2009-09-27  7:08     ` Ben Dooks
  -- strict thread matches above, loose matches on Subject: below --
2010-05-11  6:55 [PATCH v2 0/5] HP iPAQ RX1950 patch series Vasily Khoruzhick
2010-05-11  6:55 ` [PATCH v2 4/5] Add suspend/resume support for RX1950 Vasily Khoruzhick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909271001.20642.anarsoul@gmail.com \
    --to=anarsoul@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).