linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mad_soft@inbox.ru (Dmitry Artamonow)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: fix compilation of entry-common.S for older CPUs
Date: Mon, 28 Sep 2009 23:41:22 +0400	[thread overview]
Message-ID: <20090928194121.GA12304@rainbow> (raw)
In-Reply-To: <20090918162711.GA31263@pengutronix.de>

On 18:27 Fri 18 Sep     , Uwe Kleine-K?nig wrote:
> Hello,
> 
> On Fri, Sep 18, 2009 at 06:55:45PM +0400, Dmitry Artamonow wrote:
> > Commit 181f817eaaca4c1f introduced some new code to entry-common.S
> > Sadly, this new code uses 'bx' instruction which is available only on
> > ARMv5 and higher CPUs. This causes following compilation errors when
> > building kernel for StrongARM (ARMv4):
> > 
> > arch/arm/kernel/entry-common.S: Assembler messages:
> > arch/arm/kernel/entry-common.S:129: Error: selected processor does not
> >  support `bx ip'
> > arch/arm/kernel/entry-common.S:138: Error: selected processor does not
> >  support `bx ip'
> > 
> > Fix these errors by using 'mov pc' instead of 'bx'.
> > 
> > Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> 
> I wonder if newer glibc's have the same problem as the code is taken
> more or less from there ...
> 
> Thanks
> Uwe

Russell, are you ok with this fix? Should I submit patch to your patch
tracker?

(It seems that first time around patch didn't get through to you, due to your
server being picky about SMTP servers without matching reverse DNS, so
in case you haven't seen the patch on the list, I'm attaching it here again)

-- 
Best regards,
Dmitry "MAD" Artamonow

  reply	other threads:[~2009-09-28 19:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 14:55 [PATCH] arm: fix compilation of entry-common.S for older CPUs Dmitry Artamonow
2009-09-18 16:27 ` Uwe Kleine-König
2009-09-28 19:41   ` Dmitry Artamonow [this message]
2009-09-28 22:34     ` Russell King - ARM Linux
  -- strict thread matches above, loose matches on Subject: below --
2009-09-18 14:29 Dmitry Artamonow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090928194121.GA12304@rainbow \
    --to=mad_soft@inbox.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).