From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: imx: check busy bit when START/STOP
Date: Tue, 29 Sep 2009 15:09:06 +0200 [thread overview]
Message-ID: <20090929130906.GA24212@pengutronix.de> (raw)
In-Reply-To: <4e090d470909290441i7016c4f4g9a929d78838f9b7@mail.gmail.com>
Hi Richard,
On Tue, Sep 29, 2009 at 07:41:44PM +0800, Richard Zhao wrote:
> After START, wait busy bit to be set and
> after STOP, wait busy bit to be clear.
>
> Disable clock when it's possible to save power.
As those are two different issues, could you make two patches out of it? Also,
I think it will make reviewing easier if you'd drop the debug print-outs.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090929/1bb44bad/attachment.sig>
next prev parent reply other threads:[~2009-09-29 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 11:41 [PATCH] i2c: imx: check busy bit when START/STOP Richard Zhao
2009-09-29 13:09 ` Wolfram Sang [this message]
2009-09-29 13:25 ` Sascha Hauer
2009-09-29 13:54 ` Richard Zhao
2009-09-29 14:06 ` Sascha Hauer
2009-09-29 23:21 ` Richard Zhao
2009-09-29 14:24 ` Mark Brown
2009-09-29 15:14 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929130906.GA24212@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox