linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] i2c: imx: check busy bit when START/STOP
Date: Thu, 1 Oct 2009 18:37:53 +0200	[thread overview]
Message-ID: <20091001163753.GA20103@pengutronix.de> (raw)
In-Reply-To: <4e090d470910010754r1ebc4455u6220ccfd803491b0@mail.gmail.com>

> > Ah, so 'make the driver work on i.MX51' is a good statement which should
> > be part of the commit message.
> Well, maybe I can mention it.
> But I think the good point is to present what you modified, not the side effect.

It is not the side effect but the intention :) As no code is changed without a
need, the reason really should be in the patch description.

> Yes. But I don't have multi-master system. So I can't say that.
> The code is just taken from Freescale latest code. Without it, It
> could also cause a device error. I forget the details.  Anyway, it
> doesn't make anything wrong.

Do you know where the details are explained?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091001/c5b3f439/attachment.sig>

  reply	other threads:[~2009-10-01 16:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01  1:13 [PATCH 1/4] i2c: imx: check busy bit when START/STOP Richard Zhao
2009-10-01  1:13 ` [PATCH 2/4] i2c: imx: only imx1 needs disable delay Richard Zhao
2009-10-01  1:13   ` [PATCH 3/4] i2c: imx: add macros and printk to make debug easy Richard Zhao
2009-10-01  1:13     ` [PATCH 4/4] i2c: imx: disable clock when it's possible to save power Richard Zhao
2009-10-01  7:34       ` Sascha Hauer
2009-10-01  7:56         ` Richard Zhao
2009-10-01  8:00           ` Sascha Hauer
2009-10-04 12:30             ` Richard Zhao
2009-10-01  7:29     ` [PATCH 3/4] i2c: imx: add macros and printk to make debug easy Sascha Hauer
2009-10-01  8:01       ` Richard Zhao
2009-10-01  8:26         ` Sascha Hauer
2009-10-01  9:30           ` Richard Zhao
2009-10-04 12:23             ` Richard Zhao
2009-10-01  7:26   ` [PATCH 2/4] i2c: imx: only imx1 needs disable delay Sascha Hauer
2009-10-01  7:52     ` Richard Zhao
2009-10-01  7:57       ` Sascha Hauer
2009-10-01  8:03 ` [PATCH 1/4] i2c: imx: check busy bit when START/STOP Richard Zhao
2009-10-01  8:38   ` Sascha Hauer
2009-10-01  9:11     ` Richard Zhao
2009-10-01  9:52       ` Sascha Hauer
2009-10-01 14:54         ` Richard Zhao
2009-10-01 16:37           ` Wolfram Sang [this message]
2009-10-02  0:57             ` Richard Zhao
2009-10-02  7:26               ` Sascha Hauer
2009-10-02  8:17                 ` Richard Zhao
2009-10-02 14:11                   ` Wolfram Sang
2009-10-04 12:22                     ` Richard Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091001163753.GA20103@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).