From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] omap: iovmm: Add missing mutex_unlock
Date: Fri, 02 Oct 2009 15:42:50 -0700 [thread overview]
Message-ID: <20091002224250.11962.58393.stgit@localhost> (raw)
In-Reply-To: <20091002223510.11962.21751.stgit@localhost>
From: Daniel Walker <dwalker@fifo99.com>
I was using Coccinelle with the mutex_unlock semantic patch, and it
unconvered this problem. It appears to be a valid missing unlock issue.
This change should correct it by moving the unlock below the label.
This patch is against the mainline kernel.
Cc: Julia Lawall <julia@diku.dk>
Cc: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Signed-off-by: Daniel Walker <dwalker@fifo99.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/iovmm.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 0e5573d..dc3fac3 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -363,8 +363,9 @@ void *da_to_va(struct iommu *obj, u32 da)
goto out;
}
va = area->va;
- mutex_unlock(&obj->mmap_lock);
out:
+ mutex_unlock(&obj->mmap_lock);
+
return va;
}
EXPORT_SYMBOL_GPL(da_to_va);
next prev parent reply other threads:[~2009-10-02 22:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 22:36 [PATCH 0/8] Omap fixes for 2.6.32-rc2 Tony Lindgren
2009-10-02 22:37 ` [PATCH 1/8] omap: Fix incorrect 730 vs 850 detection Tony Lindgren
2009-10-02 22:38 ` [PATCH 2/8] omap: Lock DPLL5 at boot Tony Lindgren
2009-10-06 15:19 ` Paul Walmsley
2009-10-02 22:40 ` [PATCH 3/8] omap: SRAM: flush the right address after memcpy in omap_sram_push Tony Lindgren
2009-10-02 22:41 ` [PATCH 4/8] omap: iovmm: Fix incorrect spelling Tony Lindgren
2009-10-02 22:42 ` Tony Lindgren [this message]
2009-10-02 22:44 ` [PATCH 6/8] omapfb: Condition mutex acquisition Tony Lindgren
2009-10-03 18:38 ` Cory Maccarrone
2009-10-02 22:45 ` [PATCH 7/8] omapfb: Blizzard: fix pointer to be const Tony Lindgren
2009-10-02 22:46 ` [PATCH 8/8] omapfb: Blizzard: constify register address tables Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002224250.11962.58393.stgit@localhost \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).