From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] SA1100: fix building of h3100
Date: Tue, 6 Oct 2009 12:28:31 +0100 [thread overview]
Message-ID: <20091006112831.GA15695@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091006125318.d430a642.kristoffer.ericson@gmail.com>
On Tue, Oct 06, 2009 at 12:53:18PM +0200, Kristoffer Ericson wrote:
> On Mon, 5 Oct 2009 21:50:34 +0400
> Dmitry Artamonow <mad_soft@inbox.ru> wrote:
>
> > Both iPaqs h3100 and h3600 currently share the same source
> > file - h3600.c But Makefile builds it only if CONFIG_SA1100_H3600
> > selected, so selecting just CONFIG_SA1100_H3100 results in
> > "no machine record defined" message and aborted compilation.
> >
> > Fix it.
>
> Acked
If there are people seriously looking at H3[16]00 stuff, it would be
a good idea to move it over to use the proper GPIO support rather
than continue to rely upon its own version.
Also maybe splitting it into h3100.c and h3600.c, with (if any) common
bits in h3xxx.c might be an idea?
next prev parent reply other threads:[~2009-10-06 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 17:50 [PATCH] SA1100: fix building of h3100 Dmitry Artamonow
2009-10-06 10:48 ` Russell King - ARM Linux
2009-10-06 14:31 ` Dmitry Artamonow
2009-10-06 10:53 ` Kristoffer Ericson
2009-10-06 11:28 ` Russell King - ARM Linux [this message]
2009-10-06 12:51 ` Kristoffer Ericson
2009-10-06 13:05 ` Albert ARIBAUD
2009-10-06 14:38 ` Dmitry Artamonow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006112831.GA15695@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).