From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] omap: McBSP: Fix incorrect receiver stop in omap_mcbsp_stop
Date: Tue, 13 Oct 2009 17:14:53 -0700 [thread overview]
Message-ID: <20091014001453.6116.76836.stgit@localhost> (raw)
In-Reply-To: <20091014001233.6116.84749.stgit@localhost>
From: Jarkko Nikula <jhnikula@gmail.com>
This small typo written by author causes that McBSP receiver is disabled on
OMAP2430 and OMAP3430 even if only transmitter is stopped. This was noted
with ALSA SoC where simultaneous recording halted if playback was stopped
first.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/mcbsp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index 88ac976..e664b91 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -595,7 +595,7 @@ void omap_mcbsp_stop(unsigned int id, int tx, int rx)
rx &= 1;
if (cpu_is_omap2430() || cpu_is_omap34xx()) {
w = OMAP_MCBSP_READ(io_base, RCCR);
- w |= (tx ? RDISABLE : 0);
+ w |= (rx ? RDISABLE : 0);
OMAP_MCBSP_WRITE(io_base, RCCR, w);
}
w = OMAP_MCBSP_READ(io_base, SPCR1);
prev parent reply other threads:[~2009-10-14 0:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 0:13 [PATCH 0/6] omap fixes for v2.6.32-rc4 Tony Lindgren
2009-10-14 0:13 ` [PATCH 1/6] omap: Fix Unlikely(x) < y Tony Lindgren
2009-10-14 16:55 ` Tony Lindgren
2009-10-14 0:13 ` [PATCH 2/6] omap: CONFIG_ISP1301_OMAP redefined in Beagle defconfig Tony Lindgren
2009-10-14 0:14 ` [PATCH 3/6] omap: SDMA: Fixing bug in omap_dma_set_global_params() Tony Lindgren
2009-10-14 0:14 ` [PATCH 4/6] omap: RX-51: Drop I2C-1 speed to 2200 Tony Lindgren
2009-10-14 0:14 ` [PATCH 5/6] omap: Initialization of SDRC params on Zoom2 Tony Lindgren
2009-10-14 0:14 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014001453.6116.76836.stgit@localhost \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).