linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter@peter-teichmann.de (Peter Teichmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: remove references to non-existent fastfpe
Date: Wed, 14 Oct 2009 20:21:58 +0200	[thread overview]
Message-ID: <200910142021.59118.peter@peter-teichmann.de> (raw)
In-Reply-To: <4AD048A4.1070805@tuffmail.co.uk>

Am Saturday 10 October 2009 10:41:08 schrieb Alan Jenkins:
> Russell King - ARM Linux wrote:
> > On Fri, Oct 09, 2009 at 03:02:20PM +0100, Alan Jenkins wrote:
> >> 	# Do we have FASTFPE?
> >> 	FASTFPE		:=arch/arm/fastfpe
> >> 	ifeq ($(FASTFPE),$(wildcard $(FASTFPE)))
> >> 	FASTFPE_OBJ	:=$(FASTFPE)/
> >> 	endif
> >> 	fastfpe
> >>
> >> We don't have FASTFPE.  If this code still exists out of tree, it can
> >> surely maintain its own Makefile and Kconfig entries.  Let's not
> >> confuse users by allowing them to select FASTFPE, and then silently not
> >> building it.
> >
> > The code is not maintained anymore, but can just be slotted in (as per
> > the recent request on the mailing list.)  I'd rather not have the
> > hastle of maintaining fastfpe patches thank you.
>
> Urk. The fine balancing act of limbo. Another possibility would be to
> provide a stub
>
> #error "fastfpe not included; disable it or download it"
>
> But if you want to just leave it, that's obviously your decision to make.

I agree to Alan. It seems reasonable at least to include a stub as he 
suggests. However, since FastFPE was not updated for some years now, maybe 
the burden of maintaining patches is not so heavy in anymore? Maybe we can 
as well just include the latest version now? It becomes more and more 
difficult to find the source for someone who is interested in it.

What do you think?

Peter

  reply	other threads:[~2009-10-14 18:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09 14:02 [PATCH 1/6] ARM: remove unused declaration of fpundefinstr Alan Jenkins
2009-10-09 14:02 ` [PATCH 2/6] ARM: remove out of date comment Alan Jenkins
2009-10-09 14:02 ` [PATCH 3/6] ARM: update Kconfig help text for floating point Alan Jenkins
2009-10-09 14:02 ` [PATCH 4/6] ARM: remove references to non-existent fastfpe Alan Jenkins
2009-10-09 16:55   ` Russell King - ARM Linux
2009-10-10  8:41     ` Alan Jenkins
2009-10-14 18:21       ` Peter Teichmann [this message]
2009-10-14 19:03         ` Russell King - ARM Linux
2009-10-14 20:33           ` Alan Jenkins
2009-10-09 14:02 ` [PATCH 5/6] ARM: nwfpe can no longer be built as a module - remove dead code (part 1 of 2) Alan Jenkins
2009-10-09 14:02 ` [PATCH 6/6] ARM: newfpe can no longer be compiled as a module - cleanup (part 2 " Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910142021.59118.peter@peter-teichmann.de \
    --to=peter@peter-teichmann.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).