* [PATCH] ARM: NX3: do not reference mxc_iomux_v3_init() for !CONFIG_ARCH_MX35
@ 2009-10-21 18:29 Daniel Mack
2009-10-21 22:40 ` Fabio Estevam
2009-10-22 8:15 ` Sascha Hauer
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Mack @ 2009-10-21 18:29 UTC (permalink / raw)
To: linux-arm-kernel
Recent kernels for mx31 fail to link due to an undefined reference to
mxc_iomux_v3_init().
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/mach-mx3/mm.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-mx3/mm.c b/arch/arm/mach-mx3/mm.c
index ad5a112..c8acd60 100644
--- a/arch/arm/mach-mx3/mm.c
+++ b/arch/arm/mach-mx3/mm.c
@@ -81,6 +81,12 @@ void __init mx31_map_io(void)
iotable_init(mxc_io_desc, ARRAY_SIZE(mxc_io_desc));
}
+void __init mx31_init_irq(void)
+{
+ mxc_init_irq(IO_ADDRESS(AVIC_BASE_ADDR));
+}
+
+#ifdef CONFIG_ARCH_MX35
void __init mx35_map_io(void)
{
mxc_set_cpu_type(MXC_CPU_MX35);
@@ -90,15 +96,11 @@ void __init mx35_map_io(void)
iotable_init(mxc_io_desc, ARRAY_SIZE(mxc_io_desc));
}
-void __init mx31_init_irq(void)
-{
- mxc_init_irq(IO_ADDRESS(AVIC_BASE_ADDR));
-}
-
void __init mx35_init_irq(void)
{
mx31_init_irq();
}
+#endif
#ifdef CONFIG_CACHE_L2X0
static int mxc_init_l2x0(void)
--
1.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: NX3: do not reference mxc_iomux_v3_init() for !CONFIG_ARCH_MX35
2009-10-21 18:29 [PATCH] ARM: NX3: do not reference mxc_iomux_v3_init() for !CONFIG_ARCH_MX35 Daniel Mack
@ 2009-10-21 22:40 ` Fabio Estevam
2009-10-22 6:18 ` Daniel Mack
2009-10-22 8:15 ` Sascha Hauer
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2009-10-21 22:40 UTC (permalink / raw)
To: linux-arm-kernel
--- On Wed, 10/21/09, Daniel Mack <daniel@caiaq.de> wrote:
> From: Daniel Mack <daniel@caiaq.de>
> Subject: [PATCH] ARM: NX3: do not reference mxc_iomux_v3_init() for !\
There is a typo on the Subject: NX3 should be MX3.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: NX3: do not reference mxc_iomux_v3_init() for !CONFIG_ARCH_MX35
2009-10-21 18:29 [PATCH] ARM: NX3: do not reference mxc_iomux_v3_init() for !CONFIG_ARCH_MX35 Daniel Mack
2009-10-21 22:40 ` Fabio Estevam
@ 2009-10-22 8:15 ` Sascha Hauer
1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2009-10-22 8:15 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Oct 21, 2009 at 08:29:43PM +0200, Daniel Mack wrote:
> Recent kernels for mx31 fail to link due to an undefined reference to
> mxc_iomux_v3_init().
There is already a fix for this from Guennadi included in my last pull
Request. I find this in rmks master branch, so I suspect Linus hasn't
pulled from him yet.
Sascha
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/mach-mx3/mm.c | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-mx3/mm.c b/arch/arm/mach-mx3/mm.c
> index ad5a112..c8acd60 100644
> --- a/arch/arm/mach-mx3/mm.c
> +++ b/arch/arm/mach-mx3/mm.c
> @@ -81,6 +81,12 @@ void __init mx31_map_io(void)
> iotable_init(mxc_io_desc, ARRAY_SIZE(mxc_io_desc));
> }
>
> +void __init mx31_init_irq(void)
> +{
> + mxc_init_irq(IO_ADDRESS(AVIC_BASE_ADDR));
> +}
> +
> +#ifdef CONFIG_ARCH_MX35
> void __init mx35_map_io(void)
> {
> mxc_set_cpu_type(MXC_CPU_MX35);
> @@ -90,15 +96,11 @@ void __init mx35_map_io(void)
> iotable_init(mxc_io_desc, ARRAY_SIZE(mxc_io_desc));
> }
>
> -void __init mx31_init_irq(void)
> -{
> - mxc_init_irq(IO_ADDRESS(AVIC_BASE_ADDR));
> -}
> -
> void __init mx35_init_irq(void)
> {
> mx31_init_irq();
> }
> +#endif
>
> #ifdef CONFIG_CACHE_L2X0
> static int mxc_init_l2x0(void)
> --
> 1.6.5
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-22 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-21 18:29 [PATCH] ARM: NX3: do not reference mxc_iomux_v3_init() for !CONFIG_ARCH_MX35 Daniel Mack
2009-10-21 22:40 ` Fabio Estevam
2009-10-22 6:18 ` Daniel Mack
2009-10-22 8:15 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).