From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: spitz backlight: fix brightness limiting
Date: Fri, 23 Oct 2009 07:20:52 +0200 [thread overview]
Message-ID: <20091023052052.GA15499@elf.ucw.cz> (raw)
In-Reply-To: <1256251399.23211.164.camel@dax.rpnet.com>
On Thu 2009-10-22 23:43:19, Richard Purdie wrote:
> On Thu, 2009-10-22 at 04:20 +0800, Eric Miao wrote:
> > It's a little bit weird it's called 'limit_mask' when I first converted it
> > to a spi driver. There must be some reasons, Richard, you've got
> > any ideas?
>
> Its a historical artifact that once worked through some bitfield magic
> but probably stopped working when we increased the range of values the
> backlight could accept and we didn't notice the limiting problem.
>
> I'll happily take a patch to fix that.
Patch is available in the parent post. For now, I just fix it so that
it does not turn backlight off when it should not. I'll submit
limit_mask -> limit as separate patch, ok?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-10-23 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 21:37 spitz backlight: fix brightness limiting Pavel Machek
2009-10-21 20:20 ` Eric Miao
2009-10-22 7:05 ` Pavel Machek
2009-10-22 13:58 ` Eric Miao
2009-10-22 22:43 ` Richard Purdie
2009-10-23 5:20 ` Pavel Machek [this message]
2009-10-23 7:56 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091023052052.GA15499@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).