linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: staging/dream: add gpio and pmem support
Date: Tue, 27 Oct 2009 09:57:50 -0700	[thread overview]
Message-ID: <20091027165750.GA24477@kroah.com> (raw)
In-Reply-To: <20091027081921.GG5019@elf.ucw.cz>

On Tue, Oct 27, 2009 at 09:19:21AM +0100, Pavel Machek wrote:
> On Mon 2009-10-26 20:00:39, Greg KH wrote:
> > On Tue, Oct 27, 2009 at 01:17:03AM +0100, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > > This adds generic_gpio and pmem support, both are needed for other
> > > > > dream drivers.
> > > > > 
> > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > > 
> > > > I'd prefer to get the existing code building, before adding new stuff :(
> > > 
> > > Well, unfortunately other pieces depend on these.
> > 
> > The pieces already in the tree? 
> 
> Yes :-(.
> 
> > Why are you sending me patches that do
> > not build?
> 
> I did not realize how much was those drivers depenend on arch-specific part.
> 
> > > I have it building with this patch (but note that it uses -I magic; I
> > > started to write script rewriting files so that -I is not neccessary,
> > > but I did not have time to finish it yet).
> > 
> > Ok, should I just delete the whole drivers/staging/dream/ directory as
> > there seems no goal to get this to build properly?  I've just marked the
> > code as BROKEN, any chance to get it building again soon?
> 
> Could we perhaps use -I to let it build before I find time to do
> search&replace of 100 #includes? Yes, I'm working on that, but no, it
> obviously does not progress as fast as I expected...
> 
> 								Pavel
> 
> Add missing files/includes neccessary for Dream compilation.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Ick, no.  I'm not going to take the wakelock and other header files that
are "generic" to android into the dream subdir.  That's not ok.

If this code requires this mess to build, I think we should just delete
the whole thing and start over with patches that add code that can
actually build properly.

Any objection to that?

thanks,

greg k-h

  reply	other threads:[~2009-10-27 16:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22  9:13 staging/dream: add gpio and pmem support Pavel Machek
2009-10-26 23:43 ` Greg KH
2009-10-27  0:17   ` Pavel Machek
2009-10-27  3:00     ` Greg KH
2009-10-27  8:19       ` Pavel Machek
2009-10-27 16:57         ` Greg KH [this message]
2009-10-27 19:33           ` Pavel Machek
2009-10-27 20:44             ` Greg KH
2009-10-27 23:25               ` Pavel Machek
2009-10-28 15:51                 ` Greg KH
2009-10-28 21:56                   ` Pavel Machek
2009-10-28 22:11                     ` Greg KH
2009-10-28 22:41                       ` Pavel Machek
2009-10-27 22:03             ` Brian Swetland
2009-10-28 21:22               ` Pavel Machek
2009-10-28  8:59 ` Paulius Zaleckas
2009-10-28  9:05   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091027165750.GA24477@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).