From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: staging/dream: add gpio and pmem support
Date: Wed, 28 Oct 2009 08:51:16 -0700 [thread overview]
Message-ID: <20091028155116.GA1434@kroah.com> (raw)
In-Reply-To: <20091027232521.GA16782@elf.ucw.cz>
On Wed, Oct 28, 2009 at 12:25:22AM +0100, Pavel Machek wrote:
> Hi!
>
> > > What is so wrong with wakelocks? They are just nops in this case.
> >
> > Are they really? Then why is the whole large file needed?
>
> It is probably not, I went to "submit vendor code, then clean it up"
> mode. CONFIG_HAS_WAKELOCK should be disabled, so it basically stubs
> itself out.
>
> > > 2) you submit it
> >
> > Wait, it has to BUILD! This code has never been able to be built. Only
> > after I disabled it from the CONFIG_ANDROID have I noticed this, which
> > is my fault. But it needs to get fixed, and taking a bunch of code in
> > addition to the mess we have now, seems like the wrong way to do it.
>
> It seems to be the only reasonable way. gpio is used from all the
> other stuff, and removing it is not really an option.
>
> > > Now, I see that wakelocks are show-stopper for merging into kernel
> > > proper, but what is the problem for staging? We merged drivers with
> > > OS_MEMORY_ALLOCATE(); wakelocks are just nops in this case.
> > >
> > > Could we please clean this driver in-tree? (Wakelocks are already nops
> > > due to #ifdef magic, cleaning them incrementally is easy.)
> >
> > With this patch, will it build properly?
>
> Its certainly way closer to building... it builds for me, with
> something like below; platform devices really are initialized from
> board-* files and get passed parameters.
Ick. This isn't ok, we can't take patches for staging stuff in files
outside of drivers/staging/
So for now, I've deleted the drivers/staging/dream/ directory from my
tree, which will get pushed for 2.6.33. Please clean the code up and
get it into buildable shape and I will be glad to add the drivers back
into the staging directory at that time.
thanks,
greg k-h
next prev parent reply other threads:[~2009-10-28 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 9:13 staging/dream: add gpio and pmem support Pavel Machek
2009-10-26 23:43 ` Greg KH
2009-10-27 0:17 ` Pavel Machek
2009-10-27 3:00 ` Greg KH
2009-10-27 8:19 ` Pavel Machek
2009-10-27 16:57 ` Greg KH
2009-10-27 19:33 ` Pavel Machek
2009-10-27 20:44 ` Greg KH
2009-10-27 23:25 ` Pavel Machek
2009-10-28 15:51 ` Greg KH [this message]
2009-10-28 21:56 ` Pavel Machek
2009-10-28 22:11 ` Greg KH
2009-10-28 22:41 ` Pavel Machek
2009-10-27 22:03 ` Brian Swetland
2009-10-28 21:22 ` Pavel Machek
2009-10-28 8:59 ` Paulius Zaleckas
2009-10-28 9:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028155116.GA1434@kroah.com \
--to=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).