From: jamie@shareable.org (Jamie Lokier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] check put_user fail in do_signal when enable OABI_COMPACT
Date: Wed, 28 Oct 2009 19:32:34 +0000 [thread overview]
Message-ID: <20091028193234.GB17475@shareable.org> (raw)
In-Reply-To: <200910281800.47681.jpihet@mvista.com>
Jean Pihet wrote:
> usp = (u32 __user *)regs->ARM_sp;
>
> - put_user(regs->ARM_pc, usp);
> - regs->ARM_pc = KERN_RESTART_CODE;
> + if (put_user(regs->ARM_pc, usp) == 0) {
> + regs->ARM_pc = KERN_RESTART_CODE;
> + } else {
> + regs->ARM_sp += 4;
> + force_sigsegv(0, current);
> + }
> #endif
> }
> }
This one looks good to me.
-- Jamie
next prev parent reply other threads:[~2009-10-28 19:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 11:07 [PATCH] check put_user fail in do_signal when enable OABI_COMPACT Janboe Ye
2009-10-22 3:35 ` ye janboe
2009-10-24 10:49 ` Russell King - ARM Linux
2009-10-25 6:23 ` ye janboe
2009-10-25 15:44 ` Russell King - ARM Linux
2009-10-26 2:59 ` ye janboe
2009-10-27 14:14 ` Jean Pihet
2009-10-27 14:28 ` Russell King - ARM Linux
2009-10-27 14:41 ` ye janboe
2009-10-27 15:42 ` Mikael Pettersson
2009-10-27 17:57 ` Jean Pihet
2009-10-27 18:08 ` Nicolas Pitre
2009-10-27 18:37 ` Jean Pihet
2009-10-27 18:59 ` Nicolas Pitre
2009-10-27 19:12 ` Jean Pihet
2009-10-27 19:35 ` Nicolas Pitre
2009-10-27 19:42 ` Russell King - ARM Linux
2009-10-27 19:52 ` Nicolas Pitre
2009-10-28 10:16 ` Jean Pihet
2009-10-28 16:13 ` Nicolas Pitre
2009-10-28 16:23 ` Jean Pihet
2009-10-28 17:00 ` Jean Pihet
2009-10-28 17:24 ` Nicolas Pitre
2009-10-28 19:32 ` Jamie Lokier [this message]
2009-11-04 13:33 ` Jean Pihet
2009-11-04 19:32 ` Russell King - ARM Linux
2009-11-23 13:59 ` Jean Pihet
2009-11-23 14:06 ` Russell King - ARM Linux
2009-11-23 16:20 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028193234.GB17475@shareable.org \
--to=jamie@shareable.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).