From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx/gpio: Use handle_level_irq
Date: Sun, 1 Nov 2009 21:39:59 +0100 [thread overview]
Message-ID: <20091101203959.GC18116@pengutronix.de> (raw)
In-Reply-To: <20091020081303.GO8818@pengutronix.de>
On Tue, Oct 20, 2009 at 10:13:03AM +0200, Sascha Hauer wrote:
> On Mon, Oct 19, 2009 at 10:19:28PM +0200, Uwe Kleine-K?nig wrote:
> > According to Russell King handle_edge_irq is only useful for "edge-based
> > inputs where the controller does not remember transitions with the input
> > masked."
> >
> > So using handle_edge_irq unconditionally for both edge and level irqs is
> > wrong. Testing showed that the controller does remember transitions
> > while the interrupt is masked. So use handle_level_irq unconditionally.
>
> As this fixes only rt kernels and we have no reports that something is
> not working on non rt kernels I suggest putting this into the next merge
> window.
I didn't find my patch in your imx tree. Assuming I don't have
overlooked it, what is stopping you?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2009-11-01 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 20:19 [PATCH] imx/gpio: Use handle_level_irq Uwe Kleine-König
2009-10-20 8:13 ` Sascha Hauer
2009-10-20 17:37 ` Uwe Kleine-König
2009-10-23 11:27 ` Richard Zhao
2009-10-23 11:58 ` Uwe Kleine-König
2009-11-01 20:39 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091101203959.GC18116@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).