From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: s3cmci: convert missed s3c2410_gpio calls to gpiolib calls
Date: Tue, 3 Nov 2009 22:54:51 +0000 [thread overview]
Message-ID: <20091103225451.GA10599@trinity.fluff.org> (raw)
In-Reply-To: <20091103225007.605753048@fluff.org.uk>
On Tue, Nov 03, 2009 at 10:50:07PM +0000, Ben Dooks wrote:
> Convert two missed s3c2410 specific gpio calls to gpiolib calls.
>
> Signed-off-by: Ben Dooks <ben@simtec.co.uk>
> Signed-off-by: Simtec Linux Team <linux@simtec.co.uk>
>
> ---
> drivers/mmc/host/s3cmci.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> Index: b/drivers/mmc/host/s3cmci.c
> ===================================================================
> --- a/drivers/mmc/host/s3cmci.c 2009-11-03 22:17:12.000000000 +0000
> +++ b/drivers/mmc/host/s3cmci.c 2009-11-03 22:22:33.000000000 +0000
> @@ -1302,10 +1302,8 @@ static int s3cmci_get_ro(struct mmc_host
> if (pdata->no_wprotect)
> return 0;
>
> - ret = s3c2410_gpio_getpin(pdata->gpio_wprotect);
> -
> - if (pdata->wprotect_invert)
> - ret = !ret;
> + ret = s3c2410_gpio_getpin(pdata->gpio_wprotect) ? 1 : 0;
> + ret ^= pdata->wprotect_invert;
gah, should have been gpio_get_value(), reposted.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2009-11-03 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 22:50 s3cmci: convert missed s3c2410_gpio calls to gpiolib calls Ben Dooks
2009-11-03 22:54 ` Ben Dooks [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-03 22:53 Ben Dooks
2009-11-10 17:15 Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103225451.GA10599@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).