From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] Add an earlyprintk debug console
Date: Thu, 5 Nov 2009 19:17:18 +0100 [thread overview]
Message-ID: <20091105181718.GB7221@pengutronix.de> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC35608702FA4B5901@dbde02.ent.ti.com>
Hello,
On Thu, Nov 05, 2009 at 07:25:45PM +0530, Pandita, Vikram wrote:
>
> >-----Original Message-----
> >From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm-kernel-
> >bounces at lists.infradead.org] On Behalf Of Catalin Marinas
> >Sent: Thursday, November 05, 2009 4:35 AM
> >To: linux-arm-kernel at lists.infradead.org
> >Cc: Sascha Hauer; Uwe Kleine-K?nig
> >Subject: [RFC PATCH] Add an earlyprintk debug console
> >
> >This patch allows an earlyprintk console if CONFIG_DEBUG_LL is enabled,
> >using the printch asm function.
> >
> >The patch is based on the original work by Sascha Hauer.
>
> Nice work...
> Linux-omap has been using for couple of years this hackery, which finally has a solution now:
>
> diff --git a/kernel/printk.c b/kernel/printk.c
> index f38b07f..1def076 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -36,6 +36,10 @@
>
> +#ifdef CONFIG_DEBUG_LL
> + printascii(printk_buf);
> +#endif
>
> p = printk_buf;
I guess this won't be accepted, as kernel/printk.c is generic code,
CONFIG_DEBUG_LL is ARM specific. (And IIRC you need to declare
printascii first.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-11-05 18:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 12:35 [RFC PATCH] Add an earlyprintk debug console Catalin Marinas
2009-11-05 13:43 ` Sascha Hauer
2009-11-05 13:55 ` Pandita, Vikram
2009-11-05 18:17 ` Uwe Kleine-König [this message]
2009-11-05 18:15 ` Uwe Kleine-König
2009-11-06 12:22 ` Catalin Marinas
2009-11-07 22:05 ` Uwe Kleine-König
2009-11-05 20:36 ` Kristoffer Ericson
2009-11-10 7:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105181718.GB7221@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).