linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: MXC: mxcmmc: Fix max_seg_size assignment
Date: Fri, 6 Nov 2009 01:11:54 +0100	[thread overview]
Message-ID: <20091106001153.GC14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091105173251.GF21681@n2100.arm.linux.org.uk>

On Thu, Nov 05, 2009 at 05:32:51PM +0000, Russell King - ARM Linux wrote:
> Err "fix" ?  No, that's not what this is.
> 
> max_seg_size is the maximum segment size, not the maximum request size.
> The naming of these comes from the block IO subsystem, so it's a good
> idea to preserve the naming (and therefore the meaning.)
> 
> max_req_size suggests that this parameter indicates the maximum size
> of any single request.  A single request can be made up of multiple
> segments, so clearly this change is misleading.

Well - I considered that a typo only, as the left and right side were
identical:

> > -	mmc->max_seg_size = mmc->max_seg_size;

Other drivers define seg_size = reg_size, and I thought that was what
was intended here.

Daniel

  reply	other threads:[~2009-11-06  0:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05 17:13 Patches for mxcmmc.c Daniel Mack
2009-11-05 17:13 ` [PATCH 1/3] ARM: MXC: mxcmmc: misc cleanups Daniel Mack
2009-11-05 17:13   ` [PATCH 2/3] ARM: MXC: mxcmmc: Fix max_seg_size assignment Daniel Mack
2009-11-05 17:13     ` [PATCH 3/3] ARM: MXC: mxcmmc: Teach the driver SDIO operations Daniel Mack
2009-11-05 17:32     ` [PATCH 2/3] ARM: MXC: mxcmmc: Fix max_seg_size assignment Russell King - ARM Linux
2009-11-06  0:11       ` Daniel Mack [this message]
2009-11-11 14:43 ` Patches for mxcmmc.c Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091106001153.GC14091@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).